Page MenuHomeFreeBSD
Differential D787

math/gsl: Repair math/gsl build to support ARMv6
ClosedPublic
Actions

Authored by sbruno on Sep 16 2014, 2:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 5, 12:06 PM
Unknown Object (File)
Thu, Jan 30, 2:29 PM
Unknown Object (File)
Tue, Jan 28, 11:05 AM
Unknown Object (File)
Thu, Jan 9, 11:19 PM
Unknown Object (File)
Tue, Jan 7, 8:59 PM
Unknown Object (File)
Nov 29 2024, 9:59 AM
Unknown Object (File)
Nov 25 2024, 3:02 AM
Unknown Object (File)
Nov 24 2024, 7:18 AM
View All Files
Subscribers
rpaulo
ARM

Details

Reviewers
nwhitehorn
bapt
bdrewery
Summary

This port uses x86 specific ASM to generate floating point function support. DTRT for ARMv6

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

sbruno updated this revision to Diff 1644.Sep 16 2014, 2:10 PM
sbruno retitled this revision from to math/gsl: Disable for ARM platforms due to missing ieeefp support.
sbruno updated this object.
sbruno edited the test plan for this revision. (Show Details)
sbruno added reviewers: tijl, bapt, bdrewery.
sbruno added a comment.Sep 16 2014, 2:58 PM

hold on reviewing, I'll update in a bit. there might be a way to support this.

sbruno updated this revision to Diff 1646.Sep 16 2014, 4:28 PM

Actually, Nathan recognized the build failure and pointed me at the same spot
that was used to repair PPC to repair the ARM build failure. Amusing.

sbruno added a reviewer: nwhitehorn.Sep 16 2014, 4:28 PM
sbruno removed a reviewer: tijl.
sbruno added a subscriber: ARM.
sbruno retitled this revision from math/gsl: Disable for ARM platforms due to missing ieeefp support to math/gsl: Repair math/gsl build to support ARMv6.Sep 16 2014, 4:31 PM
sbruno updated this object.
rpaulo added a subscriber: rpaulo.Sep 16 2014, 4:38 PM
rpaulo added inline comments.
math/gsl/files/patch-ieee-utils-fp-freebsd.c
0

How about changing the error string as well?

0

There are a bunch of mentions to powerpc in the error strings.

0

Again here.

sbruno updated this revision to Diff 1647.Sep 16 2014, 4:46 PM

Update error strings to be more generic instead of powerpc specific

nwhitehorn edited edge metadata.Sep 16 2014, 5:15 PM

Should we have #if !defined(i386) && !defined(amd64) instead of whitelisting powerpc and arm? The stuff not being included is very x87 specific. Or use the gnuc99 fenv support, which looks like it's MI?

sbruno updated this revision to Diff 1649.Sep 16 2014, 6:00 PM
sbruno edited edge metadata.

Even more better version from nathan.

Drop patch-ieee-utils-fp-freebsd.c alltogether and change the order
of #ifdefs in the setup to pull in fp-gnuc99.c instead of fp-freebsd.cc

sbruno added a comment.Sep 16 2014, 6:08 PM

needs a redports shake I think. It built here for 11-current amd64 locally.

nwhitehorn added a comment.Sep 16 2014, 6:11 PM

I like the approach. It builds and works on powerpc64 11. It probably does need a test, but otherwise it looks good from my end.

sbruno updated this revision to Diff 1650.Sep 16 2014, 6:42 PM

Bump port revision.

sbruno added a comment.Sep 16 2014, 6:43 PM

https://redports.org/buildarchive/20140916183101-58330/

redports success build for this change

bdrewery accepted this revision.Sep 16 2014, 6:47 PM
bdrewery edited edge metadata.
This revision is now accepted and ready to land.Sep 16 2014, 6:47 PM
nwhitehorn accepted this revision.Sep 16 2014, 7:00 PM
nwhitehorn edited edge metadata.

Looks good. Thanks!

sbruno closed this revision.Sep 16 2014, 7:04 PM

Committed at svn r368343.

Revision Contents
Changeset List

Diff 1650

View Options

math/gsl/Makefile

Loading...
View Options

math/gsl/files/patch-ieee-utils-fp-freebsd.c

Loading...
View Options

math/gsl/files/patch-ieee-utils__fp.c

Loading...