Differential D53255

random: CTASSERT check sizeof random_source_descr[]
ClosedPublic
Actions

Authored by obrien on Oct 22 2025, 7:25 AM.

Tags

None

Referenced Files

	F170803289: D53255.id.diff
	Sun, Sep 6, 5:52 PM

	Unknown Object (File)
	Sat, Sep 5, 7:37 AM

	Unknown Object (File)
	Thu, Sep 3, 11:00 PM

	Unknown Object (File)
	Thu, Sep 3, 11:00 PM

	Unknown Object (File)
	Thu, Sep 3, 11:00 PM

	Unknown Object (File)
	Thu, Sep 3, 7:29 AM

	Unknown Object (File)
	Tue, Sep 1, 1:44 PM

	Unknown Object (File)
	Tue, Sep 1, 7:30 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG7d106aaa9364: random: CTASSERT check sizeof random_source_descr[]
rGd53618d58283: random: CTASSERT check sizeof random_source_descr[]
rG8bd9a9e9e4cb: random: CTASSERT check sizeof random_source_descr[]

Summary

Ensure that the number of elements of random_source_descr[]
of matches that of enum random_entropy_source.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 67987
Build 64870: arc lint + arc unit

Event Timeline

obrien created this revision.Oct 22 2025, 7:25 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 22 2025, 7:25 AM

obrien requested review of this revision.Oct 22 2025, 7:25 AM

Harbormaster completed remote builds in B67986: Diff 164731.Oct 22 2025, 7:25 AM

update review tag

Harbormaster completed remote builds in B67987: Diff 164732.Oct 22 2025, 7:26 AM

add checking of fxrng_ent_char[] too

Harbormaster completed remote builds in B68033: Diff 164846.Oct 23 2025, 4:42 AM

typo exiting editor

Harbormaster completed remote builds in B68039: Diff 164853.Oct 23 2025, 6:13 AM

tweak

Harbormaster completed remote builds in B68051: Diff 164890.Oct 23 2025, 6:08 PM

obrien added a reviewer: csprng.Oct 30 2025, 3:38 AM

obrien added a subscriber: csprng.

obrien removed a subscriber: csprng.

Otherwise LGTM

sys/dev/random/random_harvestq.c
684	The second assertion probably makes more sense colocated with the definition of ENTROPYSOURCE or hc_source_mask.

respond to comments

Harbormaster completed remote builds in B68303: Diff 165529.Oct 31 2025, 5:19 AM

obrien added inline comments.Oct 31 2025, 5:21 AM

sys/dev/random/random_harvestq.c
684	Actually I like that better - less duplication. I didn't touch fenestrasX/fx_pool.c and only added the CTASSERT to my changeset when I found so many missing items.

obrien marked an inline comment as done.Oct 31 2025, 5:21 AM

cem accepted this revision.Oct 31 2025, 5:27 AM

This revision is now accepted and ready to land.Oct 31 2025, 5:27 AM

Closed by commit rG8bd9a9e9e4cb: random: CTASSERT check sizeof random_source_descr[] (authored by obrien). · Explain WhyOct 31 2025, 6:02 PM

This revision was automatically updated to reflect the committed changes.

obrien added a commit: rG8bd9a9e9e4cb: random: CTASSERT check sizeof random_source_descr[].

obrien added a commit: rGd53618d58283: random: CTASSERT check sizeof random_source_descr[].Nov 7 2025, 12:08 AM

cperciva added a commit: rG7d106aaa9364: random: CTASSERT check sizeof random_source_descr[].Nov 7 2025, 5:17 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

random/

random_harvestq.c

6 lines

Diff 164732

sys/dev/random/random_harvestq.c

Loading...