sfxge(4): cleanup: make VPD lookups quieter
ClosedPublic
Actions

Authored by arybchik on May 14 2016, 6:25 AM.

Details

Reviewers

philip
np
gnn
bz

Commits

rS299901: sfxge(4): cleanup: make VPD lookups quieter

Summary

A lookup on a VPD entry which is missing reports several failure messages as
it propagates through wrapper functions. Restructured the wrappers to treat
this gracefully as an expected case.

Submitted by: Richard Houldsworth <rhouldsworth at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

Build sanity checked.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 3739
Build 3782: arc lint + arc unit

Event Timeline

arybchik updated this revision to Diff 16326.May 14 2016, 6:25 AM

arybchik retitled this revision from to sfxge(4): cleanup: make VPD lookups quieter.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added reviewers: gnn, philip, np, bz.

Herald added a subscriber: imp. · View Herald TranscriptMay 14 2016, 6:25 AM

Closed by commit rS299901: sfxge(4): cleanup: make VPD lookups quieter (authored by arybchik). · Explain WhyMay 16 2016, 6:26 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

ef10_vpd.c

5 lines

efx_vpd.c

6 lines

siena_vpd.c

6 lines

Diff 16326

View Options

head/sys/dev/sfxge/common/ef10_vpd.c

View Options

head/sys/dev/sfxge/common/efx_vpd.c

View Options

head/sys/dev/sfxge/common/siena_vpd.c

sfxge(4): cleanup: make VPD lookups quieterClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16326

head/sys/dev/sfxge/common/ef10_vpd.c

head/sys/dev/sfxge/common/efx_vpd.c

head/sys/dev/sfxge/common/siena_vpd.c

sfxge(4): cleanup: make VPD lookups quieter
ClosedPublic
Actions

Revision Contents
Changeset List