Page MenuHomeFreeBSD
Differential D52701

newsyslog: provide -I option to specify default signal
ClosedPublic
Actions

Authored by glebius on Sep 23 2025, 8:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 22, 1:40 PM
Unknown Object (File)
Wed, Nov 5, 4:42 PM
Unknown Object (File)
Wed, Nov 5, 9:40 AM
Unknown Object (File)
Wed, Nov 5, 9:40 AM
Unknown Object (File)
Wed, Nov 5, 9:39 AM
Unknown Object (File)
Wed, Nov 5, 9:38 AM
Unknown Object (File)
Wed, Nov 5, 9:33 AM
Unknown Object (File)
Sat, Oct 25, 4:35 PM
View All 27 Files
Subscribers
bcr
imp
ivy
ziaee

Details

Reviewers
bcr
delphij
Group Reviewers
Src Committers
Commits
rG81df9522c8b7: newsyslog: provide -I option to specify default signal
Summary

Useful when used with syslog-ng, which uses SIGUSR1. Instead of adding
signal number to every new entry, just set it via command line option.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67304
Build 64187: arc lint + arc unit

Event Timeline

glebius created this revision.Sep 23 2025, 8:11 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptSep 23 2025, 8:11 PM
glebius requested review of this revision.Sep 23 2025, 8:11 PM
Harbormaster completed remote builds in B67267: Diff 162689.Sep 23 2025, 8:12 PM
bcr added a subscriber: bcr.Sep 24 2025, 11:48 AM

Minor language corrections in the man page.

usr.sbin/newsyslog/newsyslog.8
252

s/don't/do not/
s/have signal/have a signal/

253

This option accepts either a signal number or a name as argument.

254

s/Default/The default/

glebius updated this revision to Diff 162799.Sep 25 2025, 8:27 AM

Address Benedict's review.

Harbormaster completed remote builds in B67304: Diff 162799.Sep 25 2025, 8:27 AM
bcr accepted this revision.Sep 25 2025, 11:15 AM

Thanks, ready to commit from my point of view.

This revision is now accepted and ready to land.Sep 25 2025, 11:15 AM
glebius added a reviewer: delphij.Sep 27 2025, 3:35 PM
delphij accepted this revision.Sep 28 2025, 1:42 AM

I like the change in general, but if I was you I'd probably use getopt_long() and call the option --signal (consider this as an optional suggestion; I don't have strong opinion with this choice), because -I was somewhat counterintuitive to me as a flag to specify signal and both -s and -S were already occupied.

ivy added a subscriber: ivy.Sep 28 2025, 1:53 AM
In D52701#1205432, @delphij wrote:

I like the change in general, but if I was you I'd probably use getopt_long() and call the option --signal (consider this as an optional suggestion; I don't have strong opinion with this choice), because -I was somewhat counterintuitive to me as a flag to specify signal and both -s and -S were already occupied.

i don't think we should be introducing mandatory non-standard GNU long options into base unless it's for compatibility with other platforms.

Closed by commit rG81df9522c8b7: newsyslog: provide -I option to specify default signal (authored by glebius). · Explain WhySep 28 2025, 2:55 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG81df9522c8b7: newsyslog: provide -I option to specify default signal.

Revision Contents
Changeset List

PathSize
usr.sbin/
newsyslog/
9 lines
13 lines

Diff 162799

View Options

usr.sbin/newsyslog/newsyslog.8

Loading...
View Options

usr.sbin/newsyslog/newsyslog.c

Loading...