Page MenuHomeFreeBSD
Differential D52635

release: Fail the build if pkg can't be installed
ClosedPublic
Actions

Authored by ivy on Sat, Sep 20, 2:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 3, 5:10 AM
Unknown Object (File)
Mon, Sep 29, 5:54 PM
Unknown Object (File)
Sat, Sep 27, 6:23 PM
Unknown Object (File)
Fri, Sep 26, 5:30 PM
Unknown Object (File)
Fri, Sep 26, 5:17 PM
Unknown Object (File)
Sat, Sep 20, 3:31 PM
Unknown Object (File)
Sat, Sep 20, 2:19 PM
Unknown Object (File)
Sat, Sep 20, 1:16 PM
View All 11 Files
Subscribers
ifreund_freebsdfoundation.org
imp
jrtc27

Details

Reviewers
cperciva
ifreund_freebsdfoundation.org
Commits
rG9e100a7f5631: release: Fail the build if pkg can't be installed
rG8654315ae8d3: release: Fail the build if pkg can't be installed
Summary

If we can't install pkg(8) on the media, instead of ignoring the error,
fail the build. This avoids silently creating media which doesn't have
pkg(8) on, and therefore can't be used for a pkgbase install.

Installing pkg(8) can still be entirely disabled by setting NOPKG.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy created this revision.Sat, Sep 20, 2:33 AM
Herald added subscribers: jrtc27, imp. · View Herald TranscriptSat, Sep 20, 2:33 AM
ivy requested review of this revision.Sat, Sep 20, 2:33 AM
Harbormaster completed remote builds in B67189: Diff 162453.Sat, Sep 20, 2:33 AM
ivy added a parent revision: D52634: Makefile.inc1: Fix package-pkg with a non-default LOCALBASE.Sat, Sep 20, 2:33 AM
ivy added a child revision: D52636: pkgbase-stage.lua: Add pkg package to the offline repo.
ifreund_freebsdfoundation.org accepted this revision.EditedTue, Sep 23, 1:16 PM
ifreund_freebsdfoundation.org added a subscriber: ifreund_freebsdfoundation.org.

This LGTM.

However, this has made me wonder if we handle -DNOPKG -DPKGBASE well (by erroring out I guess).

Edit: Whoops, I forgot the option changed to -DNOPKGBASE. The potentially problematic case is setting NOPKG but not NOPKGBASE.

This revision is now accepted and ready to land.Tue, Sep 23, 1:16 PM
cperciva accepted this revision.Tue, Sep 23, 8:15 PM
ivy mentioned this in D52636: pkgbase-stage.lua: Add pkg package to the offline repo.Tue, Sep 23, 8:37 PM
ivy added a comment.Tue, Sep 23, 10:18 PM
In D52635#1203535, @ifreund_freebsdfoundation.org wrote:

The potentially problematic case is setting NOPKG but not NOPKGBASE.

i haven't forgotten this, but i'm going to land this change as-is, then add some sanity checking in a separate review.

Closed by commit rG8654315ae8d3: release: Fail the build if pkg can't be installed (authored by ivy). · Explain WhyWed, Sep 24, 9:17 AM
This revision was automatically updated to reflect the committed changes.
ivy added a commit: rG8654315ae8d3: release: Fail the build if pkg can't be installed.
ivy added a commit: rG9e100a7f5631: release: Fail the build if pkg can't be installed.Thu, Sep 25, 1:02 AM

Revision Contents
Changeset List

PathSize
release/
6 lines

Diff 162716

View Options

release/Makefile

Loading...