Page MenuHomeFreeBSD
Differential D52576

arm64: Move the FEAT_PAN check later
ClosedPublic
Actions

Authored by andrew on Tue, Sep 16, 4:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 30, 8:19 AM
Unknown Object (File)
Sun, Sep 28, 5:14 PM
Unknown Object (File)
Fri, Sep 26, 12:28 AM
Unknown Object (File)
Fri, Sep 26, 12:28 AM
Unknown Object (File)
Thu, Sep 25, 5:29 AM
Unknown Object (File)
Wed, Sep 24, 7:27 AM
Unknown Object (File)
Sun, Sep 21, 7:13 PM
Unknown Object (File)
Fri, Sep 19, 9:24 PM
View All 11 Files
Subscribers
emaste
imp

Details

Reviewers
manu
emaste
Group Reviewers
arm64
Commits
rG6492b6247826: arm64: Move the FEAT_PAN check later
rG72828486ca94: arm64: Move the FEAT_PAN check later
Summary

We only need to enable PAN (Privileged access never) before userspace
is running. Before that there are no unprivileged mappings to protect
the kernel from accessing.

While here switch to use get_kernel_reg to handle the case some CPUs
have FEAT_PAN, while some don't.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Tue, Sep 16, 4:50 PM
Herald added a reviewer: manu. · View Herald TranscriptTue, Sep 16, 4:50 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Tue, Sep 16, 4:50 PM
Harbormaster completed remote builds in B67083: Diff 162173.Tue, Sep 16, 4:51 PM
andrew added a child revision: D52577: arm64: Add cpu_feat_disabled for disabled features.Tue, Sep 16, 4:51 PM
andrew added a reviewer: arm64.Tue, Sep 16, 4:52 PM
emaste added a comment.Thu, Sep 18, 2:15 PM

Is there an issue enabling it early? I agree that enabling it later is fine, just curious about the motivation for the change.

andrew added a comment.Thu, Sep 18, 3:50 PM

I'm just trying to keep things out of early boot if they don't need to be there.

emaste accepted this revision as: emaste.Thu, Sep 18, 4:17 PM
This revision is now accepted and ready to land.Thu, Sep 18, 4:17 PM
Closed by commit rG72828486ca94: arm64: Move the FEAT_PAN check later (authored by andrew). · Explain WhyFri, Sep 19, 10:36 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG72828486ca94: arm64: Move the FEAT_PAN check later.
andrew added a commit: rG6492b6247826: arm64: Move the FEAT_PAN check later.Mon, Sep 22, 3:24 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
5 lines

Diff 162390

View Options

sys/arm64/arm64/machdep.c

Loading...