Page MenuHomeFreeBSD
Differential D52530

libc++: avoid use of deprecated __reference_binds_to_temporary
ClosedPublic
Actions

Authored by arichardson on Sep 14 2025, 10:45 PM.
Tags
None
Referenced Files
F143598076: D52530.diff
Sat, Jan 31, 12:45 AM
Unknown Object (File)
Mon, Jan 5, 6:56 AM
Unknown Object (File)
Dec 24 2025, 4:12 PM
Unknown Object (File)
Dec 8 2025, 10:26 PM
Unknown Object (File)
Nov 23 2025, 8:21 AM
Unknown Object (File)
Nov 9 2025, 1:18 AM
Unknown Object (File)
Nov 1 2025, 6:25 AM
Unknown Object (File)
Oct 28 2025, 8:41 PM
View All 37 Files
Subscribers
imp

Details

Reviewers
dim
jrtc27
jhb
emaste
Commits
rG21f206bb330f: libc++: avoid use of deprecated __reference_binds_to_temporary
rGe487653fe434: libc++: avoid use of deprecated __reference_binds_to_temporary
rGdee76cf2f3da: libc++: avoid use of deprecated __reference_binds_to_temporary
Summary

This was removed in upstream libc++ in commit
437ad06f762ab07d89badecdd20627db200b98d3, but as this does not apply
cleanly to the current repository, I am applying the equivalent change
in a minimally invasive way. This is needed to build with latest clang
HEAD as of today.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 67022
Build 63905: arc lint + arc unit

Event Timeline

arichardson created this revision.Sep 14 2025, 10:45 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 14 2025, 10:45 PM
arichardson requested review of this revision.Sep 14 2025, 10:45 PM
Harbormaster completed remote builds in B67022: Diff 162023.Sep 14 2025, 10:45 PM
dim accepted this revision.Sep 15 2025, 12:09 PM
This revision is now accepted and ready to land.Sep 15 2025, 12:09 PM
emaste added inline comments.Sep 15 2025, 1:30 PM
contrib/llvm-project/libcxx/include/tuple
305

The if and elif are both __has_keyword(__reference_binds_to_temporary)?

arichardson added inline comments.Sep 15 2025, 7:10 PM
contrib/llvm-project/libcxx/include/tuple
305

The if and elif are both __has_keyword(__reference_binds_to_temporary)?

Good catch, will fix before committing!

Closed by commit rGdee76cf2f3da: libc++: avoid use of deprecated __reference_binds_to_temporary (authored by arichardson). · Explain WhySep 15 2025, 10:35 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rGdee76cf2f3da: libc++: avoid use of deprecated __reference_binds_to_temporary.
emaste added a commit: rGe487653fe434: libc++: avoid use of deprecated __reference_binds_to_temporary.Dec 15 2025, 3:03 PM
emaste added a commit: rG21f206bb330f: libc++: avoid use of deprecated __reference_binds_to_temporary.Thu, Jan 8, 5:15 PM

Revision Contents
Changeset List

PathSize
contrib/
llvm-project/
libcxx/
include/
2 lines

Diff 162023

View Options

contrib/llvm-project/libcxx/include/tuple

Loading...