Page MenuHomeFreeBSD
Differential D52513

rk_gpio: Enable gpio allocation via fdt
ClosedPublic
Actions

Authored by devivanov_proton.me on Sep 13 2025, 2:26 PM.
Tags
None
Referenced Files
F133525740: D52513.diff
Sun, Oct 26, 10:17 AM
Unknown Object (File)
Mon, Oct 13, 4:23 PM
Unknown Object (File)
Sat, Oct 11, 1:00 AM
Unknown Object (File)
Thu, Oct 9, 7:58 PM
Unknown Object (File)
Thu, Oct 9, 7:58 PM
Unknown Object (File)
Thu, Oct 9, 7:58 PM
Unknown Object (File)
Thu, Oct 9, 7:57 PM
Unknown Object (File)
Thu, Oct 9, 7:57 PM
View All 34 Files
Subscribers
emaste
imp
loos

Details

Reviewers
vexeduxr
manu
andrew
mmel
Commits
rGcddbc26251d6: rk_gpio: Enable gpio allocation via fdt
rGace98a8fb8fe: rk_gpio: Enable gpio allocation via fdt
Summary

The code is based on bcm2835_gpio.c. This enables allocating gpio interrupts via interrupts property in fdt.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 67000
Build 63883: arc lint + arc unit

Event Timeline

devivanov_proton.me created this revision.Sep 13 2025, 2:26 PM
Herald added a reviewer: andrew. · View Herald TranscriptSep 13 2025, 2:26 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added subscribers: loos, emaste, imp. · View Herald Transcript
devivanov_proton.me requested review of this revision.Sep 13 2025, 2:26 PM
Harbormaster completed remote builds in B66999: Diff 161978.Sep 13 2025, 2:26 PM
devivanov_proton.me updated this revision to Diff 161979.Sep 13 2025, 3:32 PM

Fix interrupt allocation

Harbormaster completed remote builds in B67000: Diff 161979.Sep 13 2025, 3:32 PM
vexeduxr accepted this revision.Sep 18 2025, 8:07 AM
vexeduxr added a reviewer: mmel.

LGTM, just one nit.

sys/arm64/rockchip/rk_gpio.c
698

Couldn't you just use dag here?

This revision is now accepted and ready to land.Sep 18 2025, 8:07 AM
devivanov_proton.me updated this revision to Diff 162763.Sep 24 2025, 10:24 PM

Use dag parameter directly

This revision now requires review to proceed.Sep 24 2025, 10:24 PM
Harbormaster completed remote builds in B67291: Diff 162763.Sep 24 2025, 10:24 PM
devivanov_proton.me marked an inline comment as done.Sep 24 2025, 10:24 PM
vexeduxr accepted this revision.Sep 25 2025, 9:21 AM
This revision is now accepted and ready to land.Sep 25 2025, 9:21 AM
Closed by commit rGace98a8fb8fe: rk_gpio: Enable gpio allocation via fdt (authored by devivanov_proton.me, committed by vexeduxr). · Explain WhySep 25 2025, 5:48 PM
This revision was automatically updated to reflect the committed changes.
vexeduxr added a commit: rGace98a8fb8fe: rk_gpio: Enable gpio allocation via fdt.
vexeduxr added a commit: rGcddbc26251d6: rk_gpio: Enable gpio allocation via fdt.Wed, Oct 1, 9:40 AM

Revision Contents
Changeset List

PathSize
sys/
arm64/
rockchip/
98 lines

Diff 161979

View Options

sys/arm64/rockchip/rk_gpio.c

Loading...