hyperv/stor: Disable invalid disk filtering on non-win10 or non-win 2016
ClosedPublic
Actions

Authored by honzhan_microsoft.com on May 11 2016, 5:37 AM.

Details

Reviewers

howard0su_gmail.com
decui_microsoft.com
delphij
sepherosa_gmail.com
royger

Commits

rS300656: MFC r299505
rS299505: hyperv/stor: Enable INQUIRY result check only on WIN10 like host systems

Summary

Invalid disk filtering is introduced for fixing the multiple disk issue
on windows 10 and window 2016 server.
See the bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206630

But it has issue when hot add/remove disk since the filter is not
always correct. In order to catch the FreeBSD 10.3 release on Azure,
the work around is temporarily disable this fix for win2012 R2.

The finally fix is still under investigation.

Submitted by: Hongjiang Zhang <honzhan microsoft com>

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

honzhan_microsoft.com updated this revision to Diff 16175.May 11 2016, 5:37 AM

honzhan_microsoft.com retitled this revision from to hyperv/stor: Disable invalid disk filtering on non-win10/win2k16.

honzhan_microsoft.com updated this object.

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMay 11 2016, 5:37 AM

honzhan_microsoft.com retitled this revision from hyperv/stor: Disable invalid disk filtering on non-win10/win2k16 to hyperv/stor: Disable invalid disk filtering on non-win10 or non-win 2016.May 11 2016, 5:41 AM

honzhan_microsoft.com added reviewers: decui_microsoft.com, sepherosa_gmail.com, howard0su_gmail.com, delphij, royger.

Looks good to me. Some nits, see below.

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
36	Heh, we don't want to change this :)
239	We probably don't need this; use nitems() instead.
2084	Maybe add XXX mark here? So that we can find it easily :)
sys/dev/hyperv/storvsc/hv_vstorage.h
28	Seem pretty accidental; but we have to skip this kind of changes.

honzhan_microsoft.com added inline comments.May 11 2016, 5:57 AM

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
36	Just ignore this. This happens because I copied the same file from svn.
239	Thanks. nitems is just what I want.
2084	Ok.
sys/dev/hyperv/storvsc/hv_vstorage.h
28	Yes, ignore this.