Page MenuHomeFreeBSD
Differential D52442

ix(4): Fix incomplete speed coverage in link status logging
ClosedPublic
Actions

Authored by Yogesh.Bhosale_intel.com on Sep 9 2025, 10:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 28, 1:39 PM
Unknown Object (File)
Wed, Aug 19, 12:30 AM
Unknown Object (File)
Sat, Aug 15, 1:28 AM
Unknown Object (File)
Thu, Aug 13, 1:54 AM
Unknown Object (File)
Wed, Aug 12, 7:04 PM
Unknown Object (File)
Mon, Aug 10, 2:17 PM
Unknown Object (File)
Mon, Aug 10, 7:53 AM
Unknown Object (File)
Mon, Aug 10, 5:49 AM
View All Files
Subscribers
ae
imp

Details

Reviewers
kbowling
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rG5a85a5ed44d2: ixgbe: Fix incomplete speed coverage in link status logging
rG7dc494e63774: ixgbe: Fix incomplete speed coverage in link status logging
rG98f7ad4160b1: ixgbe: Fix incomplete speed coverage in link status logging
rG46347b361975: ixgbe: Fix incomplete speed coverage in link status logging
Summary

Originally ixgbe_if_update_admin_status() only handled 1G and 10G speeds,
causing any other speeds to display as "1 Gbps" in link status logs.

This issue is fixed by adding link speed to string conversion logic through
the introduction of a helper function, ixgbe_link_speed_to_str(), which
corrects the misleading logs to reflect accurate link speeds.

Signed-off-by: Yogesh Bhosale yogesh.bhosale@intel.com

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 66916
Build 63799: arc lint + arc unit

Event Timeline

Yogesh.Bhosale_intel.com created this revision.Sep 9 2025, 10:27 AM
Owners added a reviewer: Restricted Owners Package.Sep 9 2025, 10:27 AM
Herald added subscribers: ae, imp. · View Herald TranscriptSep 9 2025, 10:27 AM
Yogesh.Bhosale_intel.com requested review of this revision.Sep 9 2025, 10:27 AM
Harbormaster completed remote builds in B66916: Diff 161777.Sep 9 2025, 10:27 AM
kbowling accepted this revision.Sep 9 2025, 4:59 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2025, 5:40 PM
Closed by commit rG46347b361975: ixgbe: Fix incomplete speed coverage in link status logging (authored by Yogesh.Bhosale_intel.com, committed by Kevin Bowling <kbowling@FreeBSD.org>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG46347b361975: ixgbe: Fix incomplete speed coverage in link status logging.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG98f7ad4160b1: ixgbe: Fix incomplete speed coverage in link status logging.Sep 12 2025, 12:36 AM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG7dc494e63774: ixgbe: Fix incomplete speed coverage in link status logging.Sep 12 2025, 12:38 AM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG5a85a5ed44d2: ixgbe: Fix incomplete speed coverage in link status logging.

Revision Contents
Changeset List

PathSize
sys/
dev/
ixgbe/
34 lines

Diff 161777

View Options

sys/dev/ixgbe/if_ix.c

Loading...