kerberos5: Fix the Heimdal pkgbase build
ClosedPublic
Actions

Authored by ivy on Sep 3 2025, 10:43 PM.

Details

Reviewers

jlduran
cy

Group Reviewers

krb5
pkgbase

Commits

rG7e97c6adffde: kerberos5: Fix the Heimdal pkgbase build

Summary

When LIB_PACKAGE was added, MIT Kerberos was updated to use it but
Heimdal was not, so it still used PACKAGE=kerberos-lib. Since we
deleted kerberos-lib-all.ucl, this caused update-packages to fail
when WITHOUT_MITKRB5 is set.

Change the Heimdal libraries to use LIB_PACKAGE by setting this in
kerberos5/lib/Makefile.inc, and remove PACKAGE=kerberos-lib from the
individual Makefiles for each library. This means Heimdal gets the
same set of packages as MIT Kerberos, except for kerberos-kdc which
we don't create for Heimdal.

Reported by: jlduran
Fixes: 929f5966a9fd ("packages: Improve handling of -lib packages")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Sep 3 2025, 10:43 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 3 2025, 10:43 PM

ivy requested review of this revision.Sep 3 2025, 10:43 PM

Harbormaster completed remote builds in B66804: Diff 161471.Sep 3 2025, 10:43 PM

@jlduran this should fix the issue you reported in D52361. i've tested that the result looks basically reasonable, but i don't use Heimdal, so i'd appreciate it if you could test this on your system.

In D52371#1195797, @ivy wrote:

@jlduran this should fix the issue you reported in D52361. i've tested that the result looks basically reasonable, but i don't use Heimdal, so i'd appreciate it if you could test this on your system.

Thank you!

This revision is now accepted and ready to land.Sep 4 2025, 12:50 AM

cy accepted this revision.Sep 4 2025, 3:38 AM

Closed by commit rG7e97c6adffde: kerberos5: Fix the Heimdal pkgbase build (authored by ivy). · Explain WhySep 4 2025, 1:54 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG7e97c6adffde: kerberos5: Fix the Heimdal pkgbase build.