release: packages: Add back UCL Kerberos libraries

[jlduran]

Summary

Fixes: 929f5966a9fd ("packages: Improve handling of -lib packages")

Test Plan

make -j $(sysctl -n hw.ncpu) packages

[jlduran]

I don't know what to put in the description, so suggestions are welcome!

[jlduran]

Add back previous file.
@ivy do you prefer to handle this fix differently?

[jlduran]

Fix typo.

[ivy]

is this the right filename? the -all suffix is used with $PKGGENNAME (see release/packages/template.ucl), but kerberos-lib is a subpackage of kerberos, so PKGNAME is kerberos-lib and PKGGENNAME is kerberos, and it should be picking up kerberos-all.ucl and kerberos-lib.ucl but not kerberos-lib-all.ucl.

or in other words, if this works, i think we have a bug somewhere in the package build, because it seems like it shouldn't (or else i'm missing something, which is quite possible).

[jlduran]

In D52361#1195557, @ivy wrote:

is this the right filename? the -all suffix is used with $PKGGENNAME (see release/packages/template.ucl), but kerberos-lib is a subpackage of kerberos, so PKGNAME is kerberos-lib and PKGGENNAME is kerberos, and it should be picking up kerberos-all.ucl and kerberos-lib.ucl but not kerberos-lib-all.ucl.

or in other words, if this works, i think we have a bug somewhere in the package build, because it seems like it shouldn't (or else i'm missing something, which is quite possible).

The error I have is:

===> Creating FreeBSD-kerberos-dbg-15.snap20250903174135
pkg -o ABI=FreeBSD:15:aarch64 -o ALLOW_BASE_SHLIBS=yes  -o OSVERSION="1500063"  create -f tzst -l -1  -M /usr/obj/usr/src/arm64.aarch64/worldstage/kerberos-dbg.ucl  -p /usr/obj/usr/src/arm64.aarch64/worldstage/kerberos-dbg.plist  -r /usr/obj/usr/src/arm64.aarch64/worldstage  -o /usr/obj/usr/src/repo/FreeBSD:15:aarch64/15.snap20250903174135
/usr/src/release/packages/generate-ucl.lua: fail to parse(/usr/src/release/packages/template.ucl): cannot open file /usr/src/release/packages/ucl/kerberos-lib-all.ucl: No such file or directory
*** [create-world-package-kerberos-lib-dbg-lib32] Error code 1

After this patch I'm getting strange pkg names. Maybe my setup is broken. Looking at pkg.FreeBSD.org everything seems OK.

I'll abandon for now. Sorry for the noise.

[ivy]

does a clean build fix it? that shouldn't be required but perhaps we're not properly cleaning something for changes like this.

[jlduran]

In D52361#1195576, @ivy wrote:

does a clean build fix it? that shouldn't be required but perhaps we're not properly cleaning something for changes like this.

Just did a clean build before. I'll setup another VM. Thanks!

[ivy]

i've done a full clean build, including deleting the repository, and i can't reproduce this, so i'm very interested to know what's going on. if you don't find the issue, could you share the full build log?

[jlduran]

In D52361#1195682, @ivy wrote:

i've done a full clean build, including deleting the repository, and i can't reproduce this, so i'm very interested to know what's going on. if you don't find the issue, could you share the full build log?

I'm currently doing a vanilla build. The previous one had MK_MITKRB5=no, also WITHOUT_BLACKLIST=, and WITHOUT_BLACKLIST_SUPPORT=. I'll let you know!

[ivy]

building without MIT Kerberos is probably the issue, it looks like i forgot to update the packages for Heimdal. i'll make another review to fix that.