Details

Reviewers

markj
emaste
fuz
arrowd

Commits

R11:35215c174c45: audio/virtual_oss_equalizer: New port

Summary

Although src commit FILLME ("virtual_oss: Port to base") includes the
equalizer utility, we do not hook it to the src build, because it
depends on the third party library fftw3, so we build it as a port
instead.

The port simply builds the files from src, which is not ideal, as this
means that the src repo needs to be present in the system in order for
the port to build, but this way we can avoid version mismatches and
ifdef hell as the project progresses.

Note that this is an extension for the base system virtual_oss, and not
audio/virtual_oss.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66799
Build 63682: arc lint + arc unit

Event Timeline

christos requested review of this revision.Wed, Sep 3, 7:04 PM

christos created this revision.

Harbormaster completed remote builds in B66794: Diff 161453.Wed, Sep 3, 7:04 PM

christos added a parent revision: D52365: audio/virtual_oss_sndio: New port.Wed, Sep 3, 7:04 PM

christos added a parent revision: D52308: virtual_oss: Port to base.Wed, Sep 3, 7:05 PM

christos edited the summary of this revision. (Show Details)

christos mentioned this in D52308: virtual_oss: Port to base.Wed, Sep 3, 7:09 PM

Please adjust the layout of the Makefile in accordance with Porter's handbook. You can use the portfmt utility for that. Please also check the portlint warning.

Please extend pkg-descr to at least three lines.

This revision now requires changes to proceed.Wed, Sep 3, 7:19 PM

Fix portlint warnings and errors.

Harbormaster completed remote builds in B66799: Diff 161460.Wed, Sep 3, 7:45 PM

The order of variables is still wrong, it would be surprising to me if portlint ate this. You can use portclippy or portfmt to automatically format the Makefile.

The points raised in D52365 also apply to this one. You can omit distinfo if there are no distfiles.

This Makefile would require a lot of fixes before getting in. @christos I can do that for you and commandeer the revision, if you wish.

In D52366#1195901, @arrowd wrote:

This Makefile would require a lot of fixes before getting in. @christos I can do that for you and commandeer the revision, if you wish.

I accept the proposition, although I'm curious what else is wrong here since neither portfmt nor portlint complain.

If they don't complain you are using them wrong, e.g. on the wrong directory.

arrowd commandeered this revision.Fri, Sep 5, 7:25 AM

arrowd edited reviewers, added: christos; removed: arrowd.

Here's my take on this port. Apart from making knobs follow the canonical order
I made following important changes:

Port building process should only write under ${WRKDIR} and ${WRKSRC} is usually a subdir of ${WRKDIR}. This is not the case for this port, so passing MAKEOBJDIRPREFIX=${WRKDIR} in MAKE_ENV is required
Port's version should depend on ${OSVERSION} so that upgrading the base would result in port's rebuild.

Harbormaster completed remote builds in B66836: Diff 161575.Fri, Sep 5, 7:29 AM