Page MenuHomeFreeBSD
Differential D52181

bsd.man.mk: Handle MANSRC.{TARGET} for MK_MANCOMPRESS=no and empty MANBUILDCAT
ClosedPublic
Actions

Authored by jhb on Aug 27 2025, 3:48 PM.
Tags
None
Referenced Files
F166406315: D52181.id161042.diff
Thu, Aug 13, 10:58 AM
Unknown Object (File)
Thu, Aug 13, 1:20 AM
Unknown Object (File)
Mon, Aug 10, 12:45 PM
Unknown Object (File)
Sat, Aug 8, 5:56 AM
Unknown Object (File)
Fri, Aug 7, 10:28 PM
Unknown Object (File)
Fri, Aug 7, 7:43 PM
Unknown Object (File)
Fri, Aug 7, 3:25 PM
Unknown Object (File)
Thu, Aug 6, 2:07 PM
View All Files
Subscribers
bdrewery
emaste
imp

Details

Reviewers
kevans
Commits
rG557cc0f350e7: bsd.man.mk: Handle MANSRC.{TARGET} for MK_MANCOMPRESS=no and empty MANBUILDCAT
Summary

Fixes: 65f60d715fd9 ("bsd.man.mk: Add a MANSRC.{TARGET} variable")
Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66575
Build 63458: arc lint + arc unit

Event Timeline

jhb created this revision.Aug 27 2025, 3:48 PM
Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptAug 27 2025, 3:48 PM
jhb requested review of this revision.Aug 27 2025, 3:48 PM
Harbormaster completed remote builds in B66563: Diff 161042.Aug 27 2025, 3:48 PM
kevans accepted this revision.Aug 27 2025, 4:00 PM
kevans added inline comments.
share/mk/bsd.man.mk
174

I'd be tempted to simplify (and the dependency below could drop the :U if so), but I do not insist. I can't think of a scenario where we'd set MANSRC for a page with a 1:1 match.

This revision is now accepted and ready to land.Aug 27 2025, 4:00 PM
jhb added inline comments.Aug 27 2025, 5:55 PM
share/mk/bsd.man.mk
174

Oh, that's fair.

jhb updated this revision to Diff 161058.Aug 27 2025, 5:59 PM

Simplify and add CLEANFILES

This revision now requires review to proceed.Aug 27 2025, 5:59 PM
Harbormaster completed remote builds in B66575: Diff 161058.Aug 27 2025, 5:59 PM
jhb marked an inline comment as done.Aug 27 2025, 5:59 PM
kevans accepted this revision.Aug 27 2025, 6:41 PM

Thanks!

This revision is now accepted and ready to land.Aug 27 2025, 6:41 PM
Closed by commit rG557cc0f350e7: bsd.man.mk: Handle MANSRC.{TARGET} for MK_MANCOMPRESS=no and empty MANBUILDCAT (authored by jhb). · Explain WhyAug 27 2025, 8:12 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG557cc0f350e7: bsd.man.mk: Handle MANSRC.{TARGET} for MK_MANCOMPRESS=no and empty MANBUILDCAT.

Revision Contents
Changeset List

PathSize
share/
mk/
11 lines

Diff 161058

View Options

share/mk/bsd.man.mk

Loading...