sh, csh: Add config tag to profile scripts in /
ClosedPublic
Actions

Authored by ivy on Aug 26 2025, 7:19 AM.

Details

Reviewers

jilles
bapt
emaste

Group Reviewers

pkgbase

Commits

rGf103de98b855: sh, csh: Add config tag to /.profile and /.cshrc
rGaa730a66bc74: sh: Add config tag to /.profile

Summary

The shell profiles /.profile and /.cshrc are installed as hard links to
/root/.profile resp. /root/.cshrc. The files in /root have the config
tag, but the files in / do not, which causes them to be overwritten by
pkg upgrade. Since they're links, this also overwrites the files in
/root.

Add the config tag to the files in / as well, so pkg treates both links
as config files and won't overwrite them.

This is a direct commit to stable/14 (these files were removed in 15.0).

PR: 289097

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66532
Build 63415: arc lint + arc unit

Event Timeline

ivy created this revision.Aug 26 2025, 7:19 AM

Herald added a reviewer: jilles. · View Herald TranscriptAug 26 2025, 7:19 AM

Herald added a subscriber: imp. · View Herald Transcript

ivy requested review of this revision.Aug 26 2025, 7:19 AM

Harbormaster completed remote builds in B66532: Diff 160988.Aug 26 2025, 7:19 AM

• grahamperrin mentioned this in D52161: sh: Remove /.profile.Aug 26 2025, 12:05 PM

• grahamperrin added a subscriber: • grahamperrin.Aug 26 2025, 12:11 PM

• grahamperrin removed a subscriber: • grahamperrin.

bapt accepted this revision.Aug 26 2025, 1:22 PM

This revision is now accepted and ready to land.Aug 26 2025, 1:22 PM

emaste accepted this revision.Aug 26 2025, 2:05 PM

• grahamperrin added a comment.Aug 26 2025, 5:14 PM

This comment was removed by • grahamperrin.

We should probably apply the bin/sh/Makefile change from here to main as well, with D52161 to follow later after resolving the issue with root's $HOME.

In D52162#1192214, @emaste wrote:

We should probably apply the bin/sh/Makefile change from here to main as well, with D52161 to follow later after resolving the issue with root's $HOME.

yes, i'll make the change for bin/sh in main and then add csh when MFC'ing it. i hope we don't have to release like this though, if only because having /.profile but not /.cshrc feels like we can't make our mind up.

jilles accepted this revision.Aug 28 2025, 3:13 PM

Closed by commit rGaa730a66bc74: sh: Add config tag to /.profile (authored by ivy). · Explain WhySep 2 2025, 8:31 AM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rGaa730a66bc74: sh: Add config tag to /.profile.