Differential D52002

random: Correct wording in a comment
ClosedPublic
Actions

Authored by markj on Aug 18 2025, 8:24 PM.

Details

Reviewers

cem

Group Reviewers

csprng

Commits

rG3d4d778262e4: random: Correct wording in a comment

Summary

In the calculation of the cutoff value, we haven't changed the window
size itself, just the example formula, which takes the window size as a
parameter.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66325
Build 63208: arc lint + arc unit

Event Timeline

markj created this revision.Aug 18 2025, 8:24 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 18 2025, 8:24 PM

markj requested review of this revision.Aug 18 2025, 8:24 PM

Herald added a subscriber: obrien. · View Herald TranscriptAug 18 2025, 8:24 PM

Harbormaster completed remote builds in B66325: Diff 160564.Aug 18 2025, 8:25 PM

markj added a child revision: D52003: random: Make random_source definitions const.Aug 18 2025, 8:25 PM

I'll take your word for it :)

This revision is now accepted and ready to land.Aug 18 2025, 8:41 PM

In D52002#1188010, @cem wrote:

I'll take your word for it :)

I could have at least provided some links:

NIST 800-90B recommendations (see footnote 10 on page 35 of the PDF): https://nvlpubs.nist.gov/nistpubs/SpecialPublications/NIST.SP.800-90B.pdf
CRITBINOM documentation: https://support.microsoft.com/en-us/office/critbinom-function-207d5482-810f-49a2-a1a8-b2e7dac01096

Closed by commit rG3d4d778262e4: random: Correct wording in a comment (authored by markj). · Explain WhyAug 19 2025, 2:09 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG3d4d778262e4: random: Correct wording in a comment.

Revision Contents
Changeset List

Path

Size

sys/

dev/

random/

random_harvestq.c

6 lines

Diff 160564

View Options

sys/dev/random/random_harvestq.c

random: Correct wording in a commentClosedPublicActions