Differential D51945

getmntpoint: Don't compare st_rdev for non-devices
ClosedPublic
Actions

Authored by des on Aug 17 2025, 1:34 PM.

Details

Reviewers

mckusick
olce
kib

Group Reviewers

Klara

Commits

rGd62cfe703fd1: getmntpoint: Don't compare st_rdev for non-devices
rG59fb30e78554: getmntpoint: Don't compare st_rdev for non-devices
rG8073a5137f22: getmntpoint: Don't compare st_rdev for non-devices

Summary

If the mntfromname of a mountpoint is not a device (e.g. nullfs, tarfs,
procfs) we shouldn't compare st_rdev, as any match will be spurious.

MFC after: 1 week
Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66298
Build 63181: arc lint + arc unit

Event Timeline

des created this revision.Aug 17 2025, 1:34 PM

Herald added a reviewer: olce. · View Herald TranscriptAug 17 2025, 1:34 PM

Herald added a subscriber: imp. · View Herald Transcript

des requested review of this revision.Aug 17 2025, 1:34 PM

Harbormaster completed remote builds in B66298: Diff 160456.Aug 17 2025, 1:34 PM

kib accepted this revision.Aug 17 2025, 1:40 PM

This revision is now accepted and ready to land.Aug 17 2025, 1:40 PM

Closed by commit rG8073a5137f22: getmntpoint: Don't compare st_rdev for non-devices (authored by des). · Explain WhyAug 17 2025, 5:30 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG8073a5137f22: getmntpoint: Don't compare st_rdev for non-devices.

des added a commit: rG59fb30e78554: getmntpoint: Don't compare st_rdev for non-devices.Aug 27 2025, 7:23 PM

des added a commit: rGd62cfe703fd1: getmntpoint: Don't compare st_rdev for non-devices.

Revision Contents
Changeset List

Path

Size

lib/

libutil/

mntopts.c

1 line

Diff 160456

View Options

getmntpoint: Don't compare st_rdev for non-devicesClosedPublicActions