libutil++: Rename manpage source files to avoid colons
ClosedPublic
Actions

Authored by jhb on Thu, Aug 7, 4:14 PM.

Details

Reviewers

ivy
emaste
olce

Commits

rG159503125826: libutil++: Rename manpage source files to avoid colons

Summary

To permit checking the sources out on systems such as Windows with
more restrictive file name requirements, rename the manpage source
files to replace colons with underscrores. Use MANSRC.foo to point
<bsd.man.mk> at the new source file names.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66065
Build 62948: arc lint + arc unit

Event Timeline

jhb created this revision.Thu, Aug 7, 4:14 PM

Herald added a reviewer: olce. · View Herald TranscriptThu, Aug 7, 4:14 PM

Herald added subscribers: ziaee, imp. · View Herald Transcript

jhb requested review of this revision.Thu, Aug 7, 4:14 PM

jhb added a parent revision: D51793: bsd.man.mk: Add a MANSRC.{TARGET} variable.

Harbormaster completed remote builds in B66065: Diff 159971.Thu, Aug 7, 4:14 PM

I initially tried using a rule to just cp foo__bar.3 to foo::bar.3 into .OBJDIR, but that failed with more errors about colons in target names and I couldn't figure out how to untangle that gracefully.

Note that the previous changes to bsd.man.mk are still required to get the versions built correctly.

I had thought about trying to use a helper variable that set the output file name (MANDEST.<mumble> or the like), but then you run into things like which compression suffix is used, etc. that I didn't want to have the client Makefiles have to know about. This approach seems the least painful.

ivy accepted this revision.Fri, Aug 22, 11:33 PM

This revision is now accepted and ready to land.Fri, Aug 22, 11:33 PM

Closed by commit rG159503125826: libutil++: Rename manpage source files to avoid colons (authored by jhb). · Explain WhyTue, Aug 26, 8:45 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG159503125826: libutil++: Rename manpage source files to avoid colons.