Page MenuHomeFreeBSD

rpcbind: Code cleanup
ClosedPublic

Authored by des on Aug 6 2025, 9:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 26, 6:41 PM
Unknown Object (File)
Sun, Oct 26, 6:38 PM
Unknown Object (File)
Sun, Oct 26, 6:38 PM
Unknown Object (File)
Sun, Oct 26, 6:37 PM
Unknown Object (File)
Sun, Oct 26, 4:05 AM
Unknown Object (File)
Sun, Oct 26, 1:36 AM
Unknown Object (File)
Sat, Oct 11, 12:07 AM
Unknown Object (File)
Sat, Oct 11, 12:06 AM
Subscribers

Details

Summary

Fix a number of style issues and attempt to reduce the diff to NetBSD.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66040
Build 62923: arc lint + arc unit

Event Timeline

des requested review of this revision.Aug 6 2025, 9:30 PM
usr.sbin/rpcbind/check_bound.c
67

Can it be const?

usr.sbin/rpcbind/rpcb_svc_4.c
401
421
423

The label should be on dedicated line.

usr.sbin/rpcbind/rpcbind.h
159

We have __DECONST(), which is more correct (cast through uintptr_t instead of long, I believe this breaks cheri). Can it be used there instead? Or at least __UNCONST can be defined as __DECONST(void *, _).

This revision is now accepted and ready to land.Aug 6 2025, 10:38 PM
des marked 5 inline comments as done.Aug 7 2025, 12:08 AM
des added inline comments.
usr.sbin/rpcbind/check_bound.c
67

Not without significant additional changes in this and other translation units.

des marked an inline comment as done.

review feedback

This revision now requires review to proceed.Aug 7 2025, 12:09 AM
This revision is now accepted and ready to land.Aug 7 2025, 12:33 AM
This revision was automatically updated to reflect the committed changes.