watchdog: Convert to using sbintime_t format
ClosedPublic
Actions

Authored by jhibbits on Feb 28 2025, 6:55 PM.

Details

Reviewers

jhb
phk
stevek
imp

Commits

rG26d6617f3e54: watchdog: Convert to using sbintime_t format

Summary

Some watchdogs are now based on a countdown timer instead of a bit
check. To deal with these, convert the watchdog framework to use
sbintime_t instead of power-of-2-nanoseconds. This allows more
precision, and more variety of watchdog timeouts. Keep the old method
as a compatibility layer, so that drivers can be migrated slowly, as
needed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66034
Build 62917: arc lint + arc unit

Event Timeline

jhibbits created this revision.Feb 28 2025, 6:55 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 28 2025, 6:55 PM

jhibbits requested review of this revision.Feb 28 2025, 6:55 PM

Harbormaster completed remote builds in B62697: Diff 151697.Feb 28 2025, 6:55 PM

jhibbits added reviewers: jhb, phk, stevek, imp.Feb 28 2025, 6:59 PM

jhibbits mentioned this in D47312: watchdog: Convert to using sbintime_t format.

jhb added inline comments.Mar 13 2025, 4:07 PM

sys/dev/watchdog/watchdog.c
198	Spurious line?
390	Hmm, you could just let these all fall through to the default case for now. Even if you want explicit case statements maybe just use: case WDIOC_GETTIMEOUT: case WDIOC_GETTIMELEFT: ... default: error = ENIOCTL;