libutil: Fix login_setcryptfmt()
ClosedPublic
Actions

Authored by des on Tue, Aug 5, 5:15 PM.

Details

Reviewers

olce
kib
markj

Commits

rGcc5276aed0c7: libutil: Fix login_setcryptfmt()

Summary

Our dummy crypt_set_format() needs to be exported, otherwise it will
be resolved at link time instead of load time, preventing the real
crypt_set_format() in libcrypt from replacing it when present.

PR: 288677
Fixes: 0c381b7f0570

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66032
Build 62915: arc lint + arc unit

Event Timeline

des created this revision.Tue, Aug 5, 5:15 PM

Herald added a reviewer: olce. · View Herald TranscriptTue, Aug 5, 5:15 PM

Herald added a subscriber: imp. · View Herald Transcript

des requested review of this revision.Tue, Aug 5, 5:15 PM

Harbormaster completed remote builds in B65984: Diff 159796.Tue, Aug 5, 5:15 PM

des added a reviewer: kib.Tue, Aug 5, 5:28 PM

emaste added a subscriber: emaste.Tue, Aug 5, 10:57 PM

Why did you put the symbol into the private namespace? It is supposed to participate in interposing with libcrypt, and apps binaries would record a reference to the symbol, am I right? I believe it must be guaranteed to be stable (as in stable ABI).

libcrypt is not versioned, so the interposing mechanism there is somewhat strengthened, but ok.

The stub does not need to be public. Its only purpose is to avoid forcing programs that link with libutil but don't use login_setcryptfmt() to also link with libcrypt. An alternate solution would be to drop the stub and have login_setcryptfmt() use dlfunc() to find crypt_set_format().