Page MenuHomeFreeBSD
Differential D51723

libutil: Backward compatibility for expand_number()
ClosedPublic
Actions

Authored by des on Aug 4 2025, 5:02 PM.
Tags
None
Referenced Files
F151111826: D51723.diff
Mon, Apr 6, 3:55 AM
Unknown Object (File)
Wed, Mar 25, 6:33 AM
Unknown Object (File)
Mon, Mar 23, 1:38 PM
Unknown Object (File)
Mon, Mar 23, 8:34 AM
Unknown Object (File)
Mon, Mar 23, 6:53 AM
Unknown Object (File)
Mon, Mar 23, 6:53 AM
Unknown Object (File)
Mon, Mar 23, 3:32 AM
Unknown Object (File)
Sun, Mar 22, 6:38 AM
View All 71 Files
Subscribers
imp
kib
ziaee

Details

Reviewers
jhb
olce
Commits
rGab1c6874e500: libutil: Backward compatibility for expand_number()
Summary

Reimplement expand_number() in terms of expand_unsigned(), which takes
a pointer to uint64_t like expand_number() did before. Provide a macro
that picks the correct version based on the type of the argument.

Fixes: 2e0caa7c7e14

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 66006
Build 62889: arc lint + arc unit

Event Timeline

des created this revision.Aug 4 2025, 5:02 PM
Herald added a reviewer: olce. · View Herald TranscriptAug 4 2025, 5:02 PM
Herald added a subscriber: imp. · View Herald Transcript
des requested review of this revision.Aug 4 2025, 5:02 PM
Harbormaster completed remote builds in B65947: Diff 159713.Aug 4 2025, 5:02 PM
des mentioned this in D51542: libutil: Really fix expand_number(3).Aug 4 2025, 5:02 PM
des updated this revision to Diff 159714.Aug 4 2025, 5:04 PM

typo

Harbormaster completed remote builds in B65948: Diff 159714.Aug 4 2025, 5:04 PM
jhb added a comment.Aug 4 2025, 5:14 PM

Looks good to me

kib added a subscriber: kib.Aug 4 2025, 9:52 PM

Don't you need to export expand_unsigned in version def?

lib/libutil/libutil.h
94

_Generic use should be braced by the C dialect check, since this is a public header.

des updated this revision to Diff 159842.Aug 6 2025, 12:32 PM

complete

Harbormaster completed remote builds in B66006: Diff 159842.Aug 6 2025, 12:32 PM
des edited the summary of this revision. (Show Details)Aug 6 2025, 12:32 PM
des updated this revision to Diff 159843.Aug 6 2025, 12:36 PM
des edited the summary of this revision. (Show Details)

nit

Harbormaster completed remote builds in B66007: Diff 159843.Aug 6 2025, 12:36 PM
des updated this revision to Diff 159854.Aug 6 2025, 1:35 PM

documentation

Herald added a subscriber: ziaee. · View Herald TranscriptAug 6 2025, 1:35 PM
Harbormaster completed remote builds in B66015: Diff 159854.Aug 6 2025, 1:35 PM
des marked an inline comment as done.Aug 6 2025, 1:39 PM
des edited the summary of this revision. (Show Details)
jhb accepted this revision.Aug 6 2025, 2:48 PM
This revision is now accepted and ready to land.Aug 6 2025, 2:48 PM
Closed by commit rGab1c6874e500: libutil: Backward compatibility for expand_number() (authored by des). · Explain WhyAug 6 2025, 8:44 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGab1c6874e500: libutil: Backward compatibility for expand_number().

Revision Contents
Changeset List

PathSize
lib/
libutil/
1 line
53 lines
8 lines
tests/
75 lines

Diff 159842

View Options

lib/libutil/Symbol.map

Loading...
View Options

lib/libutil/expand_number.c

Loading...
View Options

lib/libutil/libutil.h

Loading...
View Options

lib/libutil/tests/expand_number_test.c

Loading...