ifconfig/ifbridge.c: add get_vlan_id()
Needs ReviewPublic
Actions

Authored by ivy on Fri, Jul 11, 6:26 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jul 20, 12:56 AM

	Unknown Object (File)
	Sun, Jul 20, 12:56 AM

	Unknown Object (File)
	Sun, Jul 20, 12:56 AM

	Unknown Object (File)
	Sun, Jul 20, 12:56 AM

	Unknown Object (File)
	Sun, Jul 20, 12:56 AM

	Unknown Object (File)
	Mon, Jul 14, 11:39 AM

Subscribers

imp

Details

Reviewers

des
kevans

Group Reviewers

network

Summary

This is like get_val() but takes an ether_vlanid_t* and ensures the
value is a valid VLAN ID. This avoids redundant comparisons and
casting when parsing VLAN IDs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65335
Build 62218: arc lint + arc unit

Event Timeline

ivy created this revision.Fri, Jul 11, 6:26 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jul 11, 6:26 AM

ivy requested review of this revision.Fri, Jul 11, 6:26 AM

Harbormaster completed remote builds in B65335: Diff 158303.Fri, Jul 11, 6:26 AM

ivy added a parent revision: D51243: bridge: add ifconfig(8) vstatic/vdeladdr commands.Fri, Jul 11, 6:26 AM

ivy added a child revision: D51245: tests/sys/net/if_bridge_test: fix MTU test.Fri, Jul 11, 6:49 AM

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

ifbridge.c

66 lines

Diff 158303

View Options

ifconfig/ifbridge.c: add get_vlan_id()Needs ReviewPublicActions