Strictly speaking, they are not entirely useless. A multi-function device can expose multiple different buses, so it can add another child when gpiobus_attach_bus() is called. In an ideal world, we should have an explicit bus_attach_children() function at the end of each respective driver (especially if it exposes multiple functions).
However, this is only a theoretical notice , nothing more.

This revision is now accepted and ready to land.Wed, Jul 2, 11:20 AM

Revert the max77620 and as3722 changes. They are handled differently.

This revision now requires review to proceed.Wed, Jul 2, 3:53 PM

Harbormaster completed remote builds in B65180: Diff 157851.Wed, Jul 2, 3:53 PM

We could create a version gpiobus_attach_bus that doesn't call bus_attach_children for use by multi-function devices. That would mean all buses are added together for more control.

This revision is now accepted and ready to land.Wed, Jul 2, 4:45 PM

mmel accepted this revision.Thu, Jul 3, 7:02 AM

This looks good. No need to hold things up for Andy's suggestion, but I think I like it for future consideration.

Closed by commit rGc2d8cca77152: gpio: remove redundant calls to bus_attach_children (authored by vexeduxr). · Explain WhyFri, Jul 4, 2:08 PM

This revision was automatically updated to reflect the committed changes.

vexeduxr added a commit: rGc2d8cca77152: gpio: remove redundant calls to bus_attach_children.

vexeduxr added a commit: rG32c90988d204: gpio: remove redundant calls to bus_attach_children.Mon, Jul 7, 7:23 PM