Differential D51064

pfsync: Allocate and initialize buckets before attaching the interface
ClosedPublic
Actions

Authored by zlei on Thu, Jun 26, 2:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 12, 1:46 AM

	Unknown Object (File)
	Sat, Jul 5, 11:32 AM

	Unknown Object (File)
	Sat, Jun 28, 3:59 PM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

Commits

rG0a5e8108bf20: pfsync: Allocate and initialize buckets before attaching the interface
rG8cc376735c65: pfsync: Allocate and initialize buckets before attaching the interface
rGedc307eca9a9: pfsync: Allocate and initialize buckets before attaching the interface

Summary

This prevents a potential race that the ioctl threads see NULL or
uninitialized buckets.

Fixes: 4fc65bcbe3fb pfsync: Performance improvement
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Thu, Jun 26, 2:04 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptThu, Jun 26, 2:04 PM

zlei requested review of this revision.Thu, Jun 26, 2:04 PM

kp accepted this revision.Fri, Jun 27, 11:50 AM

This revision is now accepted and ready to land.Fri, Jun 27, 11:50 AM

Closed by commit rGedc307eca9a9: pfsync: Allocate and initialize buckets before attaching the interface (authored by zlei). · Explain WhySat, Jun 28, 3:49 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGedc307eca9a9: pfsync: Allocate and initialize buckets before attaching the interface.

zlei added a commit: rG8cc376735c65: pfsync: Allocate and initialize buckets before attaching the interface.Mon, Jul 7, 10:09 AM

zlei added a commit: rG0a5e8108bf20: pfsync: Allocate and initialize buckets before attaching the interface.Tue, Jul 8, 10:06 AM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

33 lines

Diff 157724

sys/netpfil/pf/if_pfsync.c

Loading...