Differential D50863
LinuxKPI: acpi: provide union [linuxkpi]_acpi_(object|buffer) Authored by bz on Jun 15 2025, 11:01 AM. Tags None Referenced Files
Details Provide union acpi_(object|buffer) as linuxkpi_ versions and in Linux Use the linuxkpi_ prefix to avoid name clashes with the native ACPI Use the linuxkpi_ names internally and redefine the linuxkpi_ unions Sponsored by: The FreeBSD Foundation
Diff Detail
Event TimelineComment Actions General convention in at least drm-kmod is to not redefine ACPICA objects if it is possible. Porting of this code is mostly just a changing of symbol case and adding/removing of underscores. drm-kmod does not even guards these changes with #ifdefs Comment Actions I picked a random file ( in v6.6 drivers/gpu/drm/radeon/radeon_acpi.c ) and it seems everything there got CamelCased without any #ifdefs. It's just an unnecessary diff to vendor and maintenance. No idea how much of this was done in drm-kmod but I am not going to rewrite case in entire files because of this. I had not compiled files or #ifdef'ed out the entire logic. Not gong to fly anymore. Remove the #ifdefs from drm-kmod and reduce the diff to upstream and make maintenance easier by having one place to edit and not 117. That's what LinuxKPI is for. Comment Actions Yes, I need to spend some time to expand linuxkpi so that we can get rid of all these ifdefs in drm-kmod. Comment Actions There is no #ifdefs in drm-kmod. Just a trivial changing of cases in couple of files. I am afraid, you are trying to open a can of worms with introduction of ACPICA wrappers. Comment Actions It is not about of proper symbols. It is about of adding of LKPI objects which differs only in character case in the name Comment Actions Which is just as trivial to paper over with #defines so you don't have to change it next time which makes future ports faster since you don't have to detour around already solved trivial problems. When I've done it for other things in the tree, it's helped prevent death of a thousand cuts... Comment Actions As number of object types we handle in LKPI does not exceed 10 it may counts as not a rewrite of ACPICA Comment Actions Update the change to not break drm-kmod on all supported branches right away. Go the extra mile to add a preprocessor condition to switch between the current The suggestion is to commit this with a FreeBSD_verion bump to main. Then the supproted drm-kmod branches can be cleaned up conditionally based on Sorry for these extra hoops but the unconditional in-place editing in drm-kmod I've compile amd64, arm64, and i386 universe for 5.15-lts, 6.1-lts, and |