Paths

Table of Contentst

Differential D50979

dev/psci: Use the correct SMCCC TRNG field
ClosedPublic
Actions

Authored by andrew on Mon, Jun 23, 12:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jul 11, 3:26 AM

	Unknown Object (File)
	Wed, Jun 25, 11:23 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG5ec268d09a2e: dev/psci: Use the correct SMCCC TRNG field

Summary

The TRNG service will return random data in x3. Use the correct field
when filling the buffer in trng_read.

This driver has not been in any release, so no security advisory is
needed.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Mon, Jun 23, 12:46 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jun 23, 12:46 PM

andrew requested review of this revision.Mon, Jun 23, 12:46 PM

andrew added a parent revision: D50978: dev/psci: Check for functions before calling.

Harbormaster completed remote builds in B65026: Diff 157449.Mon, Jun 23, 12:46 PM

bz accepted this revision.Tue, Jun 24, 8:47 PM

bz added a subscriber: bz.

bz added inline comments.

sys/dev/psci/smccc_trng.c
116	Why are we limiting ourselves to 64 bits when the TRNG can return 192 on SMC64? Or do I misread https://developer.arm.com/documentation/den0098/latest/ ? it leads to the next question below:
125	While true for 64bit of entropy as limited above for SMC64, I assume we do not use this on SCM32 (seems we don't). Can we extend this to allow up-to 192 bits of entropy and use A3..A2..A1 for [0..63][64..127][128..191]? Does it make sense to do so?

This revision is now accepted and ready to land.Tue, Jun 24, 8:47 PM

andrew added inline comments.Wed, Jun 25, 9:30 AM

sys/dev/psci/smccc_trng.c
116	`random_sources_feed` only ever asks for 64-bits so it simplifies the code to just read that

Closed by commit rG5ec268d09a2e: dev/psci: Use the correct SMCCC TRNG field (authored by andrew). · Explain WhyWed, Jun 25, 11:23 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG5ec268d09a2e: dev/psci: Use the correct SMCCC TRNG field.

Revision Contents
Changeset List

Path

Size

sys/

dev/

psci/

2 lines

Diff 157594

sys/dev/psci/smccc_trng.c

Loading...