Page MenuHomeFreeBSD
Differential D51027

lockf: minor cosmetic cleanups, no functional change
ClosedPublic
Actions

Authored by kevans on Tue, Jun 24, 11:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 10, 6:41 PM
Unknown Object (File)
Mon, Jul 7, 2:09 PM
Unknown Object (File)
Thu, Jul 3, 8:12 PM
Unknown Object (File)
Thu, Jul 3, 4:24 PM
Unknown Object (File)
Thu, Jul 3, 6:38 AM
Unknown Object (File)
Sat, Jun 28, 6:08 AM
Subscribers
imp
kib

Details

Reviewers
allanjude
des
kib
Commits
rG4c8b54f765c7: lockf: minor cosmetic cleanups, no functional change
Summary

Switch various flags from int -> bool.

kill(getpid(), foo) and raise(foo) are equivalent in this context, so
switch to the latter as a minor preference for readability.

Use proper signal fences instead of volatile for our SIGAALRM handler.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65067
Build 61950: arc lint + arc unit

Event Timeline

kevans created this revision.Tue, Jun 24, 11:21 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Jun 24, 11:21 PM
kevans requested review of this revision.Tue, Jun 24, 11:21 PM
Harbormaster completed remote builds in B65067: Diff 157557.Tue, Jun 24, 11:21 PM
kevans added a parent revision: D51026: lockf: tests: add tests for the -p and -T features.Tue, Jun 24, 11:21 PM
kevans added a reviewer: kib.Tue, Jun 24, 11:22 PM
kevans added a subscriber: kib.

Adding @kib to validate fence usage.

kib accepted this revision.Tue, Jun 24, 11:41 PM
This revision is now accepted and ready to land.Tue, Jun 24, 11:41 PM
kevans mentioned this in D51025: lockf: add a -T option to terminate the child upon early abort.Wed, Jun 25, 12:17 PM
des added inline comments.Wed, Jun 25, 1:12 PM
usr.bin/lockf/lockf.c
66
137

this is ugly, I would hoist errstr to function scope and drop the braces.

231
233
kevans updated this revision to Diff 157640.Thu, Jun 26, 3:03 AM
kevans marked 4 inline comments as done.

Address review feedback

This revision now requires review to proceed.Thu, Jun 26, 3:03 AM
Harbormaster completed remote builds in B65094: Diff 157640.Thu, Jun 26, 3:03 AM
des accepted this revision.Tue, Jul 1, 10:51 AM
This revision is now accepted and ready to land.Tue, Jul 1, 10:51 AM
Closed by commit rG4c8b54f765c7: lockf: minor cosmetic cleanups, no functional change (authored by kevans). · Explain WhyThu, Jul 10, 5:55 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG4c8b54f765c7: lockf: minor cosmetic cleanups, no functional change.

Revision Contents
Changeset List

PathSize
usr.bin/
lockf/
21 lines

Diff 157557

View Options

usr.bin/lockf/lockf.c

Loading...