newvers: Add a builddir parameter
ClosedPublic
Actions

Authored by markj on Jun 20 2025, 5:13 PM.

Details

Reviewers

emaste
brooks
bnovkov
kevans
imp

Commits

rGde659254dcb6: newvers: Add a builddir parameter
rG3238878379d3: newvers: Add a builddir parameter

Summary

When reproducible builds are configured, we should use /usr/obj as the
canonical objdir. Add a parameter to newvers.sh to ensure that build
metadata is reproducible.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64998
Build 61881: arc lint + arc unit

Event Timeline

markj requested review of this revision.Jun 20 2025, 5:13 PM

markj created this revision.

Harbormaster completed remote builds in B64998: Diff 157388.Jun 20 2025, 5:13 PM

markj added a parent revision: D50953: sys/conf: Remap paths for reproducibility.Jun 20 2025, 5:13 PM

markj added a child revision: D50955: ncurses: Provide reproducible paths.

emaste accepted this revision.Jun 20 2025, 6:21 PM

This revision is now accepted and ready to land.Jun 20 2025, 6:21 PM

I believe this one is generally not necessary in practice, as in reproducible build mode we already elide the objdir entirely.

In D50954#1171688, @emaste wrote:

I believe this one is generally not necessary in practice, as in reproducible build mode we already elide the objdir entirely.

Note that d, derived from $(pwd), is embedded directly into VERSTR. Without this change, when running uname -v, you'll see the value of $(pwd) embedded in the kernel build directory.