Differential D50921

libc,libthr: Remove __pthread_distribute_static_tls
Needs ReviewPublic
Actions

Authored by jrtc27 on Wed, Jun 18, 9:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 28, 12:19 PM

	Unknown Object (File)
	Thu, Jun 26, 10:47 AM

	Unknown Object (File)
	Wed, Jun 25, 5:46 AM

	Unknown Object (File)
	Wed, Jun 25, 5:39 AM

	Unknown Object (File)
	Tue, Jun 24, 5:40 PM

	Unknown Object (File)
	Sun, Jun 22, 8:58 PM

	Unknown Object (File)
	Thu, Jun 19, 3:55 PM

	Unknown Object (File)
	Thu, Jun 19, 3:44 PM

View All 10 Files

Subscribers

Details

Reviewers

Summary

This private API is no longer used by rtld-elf so can be removed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 64960
Build 61843: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Wed, Jun 18, 9:31 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Jun 18, 9:31 PM

jrtc27 requested review of this revision.Wed, Jun 18, 9:31 PM

Harbormaster completed remote builds in B64960: Diff 157278.Wed, Jun 18, 9:31 PM

jrtc27 added a parent revision: D50920: rtld-elf: Track allocated TCBs internally and use for distribute_static_tls.Wed, Jun 18, 9:31 PM

kib added inline comments.Wed, Jun 18, 10:43 PM

lib/libc/gen/libc_interposing_table.c
45	My opinion is that we should keep the slot unused if we remove the interposer. If anything, this would make the upgrades easier, and not break half-upgraded systems to the state where /rescue must be used.

jrtc27 added inline comments.Wed, Jun 18, 10:55 PM

lib/libc/gen/libc_interposing_table.c
45	As in turn it into __INTERPOS_reserved0, and allow it to be reused after one release cycle when we know the slot definitely won't be in use by system libraries any more?

kib added inline comments.Wed, Jun 18, 11:06 PM

lib/libc/gen/libc_interposing_table.c
45	Not sure about reuse, but for now yes, just reserve the index in the table.

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

1 line

26 lines

libc_interposing_table.c

1 line

include/

3 lines

libthr/

1 line

thread/

38 lines

2 lines

Diff 157278

lib/libc/gen/Symbol.map

Loading...

lib/libc/gen/elf_utils.c

Loading...

lib/libc/gen/libc_interposing_table.c

Loading...

lib/libc/include/libc_private.h

Loading...

lib/libthr/pthread.map

Loading...

lib/libthr/thread/thr_list.c

Loading...

lib/libthr/thread/thr_private.h

Loading...