release: Add set -e to abort upon failure
ClosedPublic
Actions

Authored by emaste on Jun 6 2025, 2:18 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jul 8, 11:22 PM

	Unknown Object (File)
	Mon, Jul 7, 5:23 AM

	Unknown Object (File)
	Fri, Jul 4, 10:19 PM

	Unknown Object (File)
	Fri, Jul 4, 10:19 PM

	Unknown Object (File)
	Fri, Jul 4, 10:19 PM

	Unknown Object (File)
	Fri, Jul 4, 10:19 PM

	Unknown Object (File)
	Fri, Jul 4, 10:19 PM

	Unknown Object (File)
	Fri, Jul 4, 10:19 PM

Subscribers

Details

Reviewers

cperciva

Group Reviewers

releng

Commits

rG611c1457ff32: release: Add set -e to abort upon failure

Summary

We don't want to blindly continue and produce broken images if something
goes wrong.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Jun 6 2025, 2:18 AM

Herald added a subscriber: jrtc27. · View Herald TranscriptJun 6 2025, 2:18 AM

emaste requested review of this revision.Jun 6 2025, 2:18 AM

This seems fine in principle, but it'll probably break some targets which rely on ignoring errors.

Please don't MFC until we've got everything fixed. But now is a good time to get this into the tree.

This revision is now accepted and ready to land.Tue, Jun 17, 5:39 PM

Closed by commit rG611c1457ff32: release: Add set -e to abort upon failure (authored by emaste). · Explain WhyTue, Jun 17, 5:41 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG611c1457ff32: release: Add set -e to abort upon failure.

Herald added a subscriber: imp. · View Herald TranscriptTue, Jun 17, 5:41 PM

Revision Contents
Changeset List

Path

Size

release/

scripts/

mk-vmimage.sh

1 line

Diff 157207

View Options

release/scripts/mk-vmimage.sh

release: Add set -e to abort upon failureClosedPublicActions