tests: Update for jemalloc's option parsing
ClosedPublic
Actions

Authored by emaste on Jun 17 2025, 3:35 PM.

Details

Reviewers

jilles
markj
olce

Commits

rG1ff48c6810a1: tests: Update for jemalloc's option parsing
rG4f33d073003c: tests: Update for jemalloc's option parsing

Summary

MALLOC_OPTIONS=J -> MALLOC_CONF=junk:true

PR:             287357
Event:          Kitchener-Waterloo Hackathon 202506
Sponsored by:   The FreeBSD Foundation

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Jun 17 2025, 3:35 PM

Herald added a reviewer: jilles. · View Herald TranscriptJun 17 2025, 3:35 PM

emaste requested review of this revision.Jun 17 2025, 3:35 PM

include bpf tests in same review

markj accepted this revision.Jun 17 2025, 3:51 PM

This revision is now accepted and ready to land.Jun 17 2025, 3:51 PM

Closed by commit rG4f33d073003c: tests: Update for jemalloc's option parsing (authored by emaste). · Explain WhyJun 17 2025, 3:53 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG4f33d073003c: tests: Update for jemalloc's option parsing.

Herald added a subscriber: imp. · View Herald TranscriptJun 17 2025, 3:53 PM

Seems fine.

There's also a couple of occurences of MALLOC_OPTIONS in contrib code (bmake, openssh (they just don't support MALLOC_CONF in their configure.ac)), I guess you want to handle separately (or not right now)?

Seems we could change also usr.bin/bmake/unit-tests/Makefile (not contrib).

The PR has a list -- usr.bin/bmake/unit-tests/Makefile has both MALLOC_CONF and MALLOC_OPTIONS set so it's fine, although inconsistent between the two.

In D50910#1162053, @emaste wrote:

The PR has a list -- usr.bin/bmake/unit-tests/Makefile has both MALLOC_CONF and MALLOC_OPTIONS set so it's fine, although inconsistent between the two.

Hadn't seen the PR.

emaste added a commit: rG1ff48c6810a1: tests: Update for jemalloc's option parsing.Sep 3 2025, 1:07 PM