virtual_oss: Clean up pthread on exit
AbandonedPublic
Actions

Authored by christos on May 23 2025, 5:15 PM.

Details

Reviewers

adrian
emaste
markj

Summary

To do that we also need to cache the thread pointers so that we can use
them later in destroy_threads(). Also add error checking on pthread
functions whose return values we care about.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

christos requested review of this revision.May 23 2025, 5:15 PM

christos created this revision.

christos added a parent revision: D50493: virtual_oss: Clean up cuse on exit.

christos added a child revision: D50495: virtual_oss: Clean up audio delay unit on exit.

Full diff.

markj accepted this revision.May 25 2025, 6:09 PM

markj added inline comments.

virtual_main.c
2680	I don't see much benefit to explicitly freeing memory right before the process exits.

This revision is now accepted and ready to land.May 25 2025, 6:09 PM

christos added inline comments.May 27 2025, 12:54 PM

virtual_main.c
2680	I'm aware the OS will clean up resources anyway, but isn't it better to make sure we clean up on our part?

markj added inline comments.May 27 2025, 1:05 PM

virtual_main.c
2680	The only reason it might be better to clean up is to future-proof it, in case this code is copied into a library for instance. But in that case the change is incomplete, since presumably we'd need to clean up in the error cases as well.

Remove atomic_destroy().

This revision now requires review to proceed.May 28 2025, 3:30 PM

Committed: https://github.com/freebsd/virtual_oss/commit/fcf3d0e7d1e3b351975f444606ba30d1e5106fbf

Revision Contents
Changeset List

Path

Size

virtual_main.c

34 lines

Diff 156198

View Options

virtual_oss: Clean up pthread on exitAbandonedPublicActions