sndctl(8): Fix dp->realtime
ClosedPublic
Actions

Authored by christos on May 17 2025, 9:05 PM.

Details

Reviewers

markj
emaste
adrian

Commits

rG623ccbc4e4f2: sndctl(8): Fix dp->realtime
rG30fd79b0c0a3: sndctl(8): Fix dp->realtime

Summary

Currently it's automatically set to 0 in read_dev() as a result of
allocating dp with calloc().

Sponsored by: The FreeBSD Foundation
MFC after: 1 day

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64264
Build 61148: arc lint + arc unit

Event Timeline

christos created this revision.May 17 2025, 9:05 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 17 2025, 9:05 PM

Harbormaster completed remote builds in B64252: Diff 155630.May 17 2025, 9:05 PM

christos requested review of this revision.May 17 2025, 9:05 PM

christos added a parent revision: D50399: sndctl(8): Do not re-read device at the end.

markj accepted this revision.May 18 2025, 3:40 PM

This revision is now accepted and ready to land.May 18 2025, 3:40 PM

Reflect D50398 changes.

This revision now requires review to proceed.May 18 2025, 4:07 PM

Harbormaster completed remote builds in B64264: Diff 155649.May 18 2025, 4:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 21 2025, 7:32 PM

Closed by commit rG30fd79b0c0a3: sndctl(8): Fix dp->realtime (authored by christos). · Explain Why

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG30fd79b0c0a3: sndctl(8): Fix dp->realtime.

christos added a commit: rG623ccbc4e4f2: sndctl(8): Fix dp->realtime.May 22 2025, 6:25 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

sndctl/

sndctl.c

189 lines

Diff 155649

View Options

sndctl(8): Fix dp->realtimeClosedPublicActions