Page MenuHomeFreeBSD
Differential D50398

sndctl(8): Allow read-only sysctls
ClosedPublic
Actions

Authored by christos on May 17 2025, 9:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 22, 11:52 AM
Unknown Object (File)
Mon, May 18, 3:02 PM
Unknown Object (File)
Wed, Apr 29, 9:53 AM
Unknown Object (File)
Wed, Apr 29, 8:53 AM
Unknown Object (File)
Wed, Apr 29, 6:13 AM
Unknown Object (File)
Wed, Apr 29, 6:07 AM
Unknown Object (File)
Wed, Apr 29, 2:03 AM
Unknown Object (File)
Wed, Apr 29, 2:01 AM
View All 89 Files
Subscribers
imp

Details

Reviewers
markj
emaste
adrian
Commits
rG2af8f2ad4265: sndctl(8): Allow read-only sysctls
rG52c426327403: sndctl(8): Allow read-only sysctls
Summary

Needed by follow-up patch.

Sponsored by: The FreeBSD Foundation
MFC after: 1 day

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64250
Build 61134: arc lint + arc unit

Event Timeline

christos created this revision.May 17 2025, 9:04 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 17 2025, 9:04 PM
christos requested review of this revision.May 17 2025, 9:04 PM
christos added a parent revision: D50397: sndctl(8): Remove unnecessary val variable from sysctl functions.
Harbormaster completed remote builds in B64250: Diff 155628.May 17 2025, 9:04 PM
christos added a child revision: D50399: sndctl(8): Do not re-read device at the end.May 17 2025, 9:04 PM
markj added inline comments.May 18 2025, 3:37 PM
usr.sbin/sndctl/sndctl.c
676

For such simple code, it's IMO better to just use an if-statement:

if (arg != NULL) {
    n = strtol(...)
    ...
}
679

For this to work correctly, you need to set errno = 0 before the strtol() call.

christos updated this revision to Diff 155648.May 18 2025, 4:06 PM
christos marked 2 inline comments as done.

Address Mark's comments.

Harbormaster completed remote builds in B64263: Diff 155648.May 18 2025, 4:06 PM
christos mentioned this in D50400: sndctl(8): Fix dp->realtime.May 18 2025, 4:07 PM
markj accepted this revision.May 18 2025, 6:24 PM
This revision is now accepted and ready to land.May 18 2025, 6:24 PM
Closed by commit rG52c426327403: sndctl(8): Allow read-only sysctls (authored by christos). · Explain WhyMay 21 2025, 7:32 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG52c426327403: sndctl(8): Allow read-only sysctls.
christos added a commit: rG2af8f2ad4265: sndctl(8): Allow read-only sysctls.May 22 2025, 6:25 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
sndctl/
29 lines

Diff 155628

View Options

usr.sbin/sndctl/sndctl.c

Loading...