Page MenuHomeFreeBSD
Differential D50364

sh: Avoid referencing uninitialized memory in alias
ClosedPublic
Actions

Authored by jrm on May 15 2025, 3:13 PM.
Tags
None
Referenced Files
F170695953: D50364.id155518.diff
Sun, Sep 6, 1:59 AM
F170639435: D50364.id.diff
Sat, Sep 5, 6:29 PM
Unknown Object (File)
Sat, Sep 5, 10:11 AM
Unknown Object (File)
Sat, Sep 5, 7:17 AM
Unknown Object (File)
Sat, Sep 5, 12:43 AM
Unknown Object (File)
Fri, Sep 4, 1:19 PM
Unknown Object (File)
Thu, Sep 3, 5:51 AM
Unknown Object (File)
Wed, Sep 2, 11:08 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
pstef
mckusick
jilles
Commits
rG1b3972ac0f75: sh: Avoid referencing uninitialized memory in alias
rG9d29fc2e4bfb: sh: Avoid referencing uninitialized memory in alias
Summary

If run as
alias ''
uninitialized memory could be referenced.

This is based on a fix from NetBSD. For more information, refer to the
commit log in
https://github.com/NetBSD/src/commit/10cfed82c282ff96a5a8818a9ce9b0e7444d418d

Obtained from: NetBSD (kre)
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64201
Build 61085: arc lint + arc unit

Event Timeline

jrm created this revision.May 15 2025, 3:13 PM
Herald added a reviewer: jilles. · View Herald TranscriptMay 15 2025, 3:13 PM
Herald added a subscriber: imp. · View Herald Transcript
jrm requested review of this revision.May 15 2025, 3:13 PM
Harbormaster completed remote builds in B64201: Diff 155518.May 15 2025, 3:13 PM
emaste accepted this revision.May 15 2025, 3:40 PM

Heh,

$ /bin/sh
$ alias '' ==
$ alias
Bus error (core dumped)
$
This revision is now accepted and ready to land.May 15 2025, 3:40 PM
emaste requested changes to this revision.May 15 2025, 3:45 PM
emaste added inline comments.
bin/sh/alias.c
208

n is by definition an empty string, so the message would be alias: : not found which is confusing

This revision now requires changes to proceed.May 15 2025, 3:45 PM
jrm updated this revision to Diff 155558.May 16 2025, 1:48 PM

Improve error message

Harbormaster completed remote builds in B64217: Diff 155558.May 16 2025, 1:49 PM
emaste accepted this revision.May 16 2025, 1:57 PM
This revision is now accepted and ready to land.May 16 2025, 1:57 PM
Closed by commit rG9d29fc2e4bfb: sh: Avoid referencing uninitialized memory in alias (authored by jrm). · Explain WhyMay 16 2025, 2:04 PM
This revision was automatically updated to reflect the committed changes.
jrm added a commit: rG9d29fc2e4bfb: sh: Avoid referencing uninitialized memory in alias.
jrm added a commit: rG1b3972ac0f75: sh: Avoid referencing uninitialized memory in alias.Jan 28 2026, 1:06 AM

Revision Contents
Changeset List

PathSize
bin/
sh/
5 lines

Diff 155518

View Options

bin/sh/alias.c

Loading...