cxgbetool.8: Fix Minor mechanical issues
ClosedPublic
Actions

Authored by ziaee on May 13 2025, 12:44 AM.

Details

Reviewers

jhb
carlavilla
mhorne

Group Reviewers

manpages

Commits

rGd7207388cc58: cxgbetool.8: Fix some minor mechanical issues
rG8f25fac9ce23: cxgbetool.8: Fix some minor mechanical issues

Summary

+ Tag SPDX
+ Macros should not appear in titles, write a hopefully better title
+ Nm needs to be on it's own line in SYNOPSIS, fold it so this page

does not appear in unrelated search results (test case `apropos fw`)

+ Remove Ns's that do nothing and generate linter errors
+ Move list initializers to where they render, correcting linter errors

Unresolved:
This page produces an error when rendered due to the table. I don't know
how to fix that yet, but I'm interested in learning!

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64117
Build 61001: arc lint + arc unit

Event Timeline

ziaee created this revision.May 13 2025, 12:44 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 13 2025, 12:44 AM

ziaee requested review of this revision.May 13 2025, 12:44 AM

Harbormaster completed remote builds in B64117: Diff 155363.May 13 2025, 12:44 AM

ziaee retitled this revision from cxgbetool.8: Fix some mechanical issues to cxgbetool.8: Fix Minor mechanical issues.May 13 2025, 1:23 AM

mhorne accepted this revision.May 13 2025, 2:03 PM

mhorne added inline comments.

usr.sbin/cxgbetool/cxgbetool.8
40	Right?
706–708	Or the correct/appropriate wrapping.

This revision is now accepted and ready to land.May 13 2025, 2:03 PM

mhorne added inline comments.May 13 2025, 2:15 PM

usr.sbin/cxgbetool/cxgbetool.8
40	Right? Wrong, apparently. https://english.stackexchange.com/questions/315198/does-ethernet-need-to-be-capitalised

Closed by commit rG8f25fac9ce23: cxgbetool.8: Fix some minor mechanical issues (authored by ziaee). · Explain WhyMay 19 2025, 2:58 AM

This revision was automatically updated to reflect the committed changes.

ziaee added a commit: rG8f25fac9ce23: cxgbetool.8: Fix some minor mechanical issues.

Thanks so much for being thorough and looking into these for me. I think we're improving the quality.

ziaee added a commit: rGd7207388cc58: cxgbetool.8: Fix some minor mechanical issues.Fri, Feb 6, 12:42 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

cxgbetool/

cxgbetool.8

177 lines

Diff 155363

View Options

usr.sbin/cxgbetool/cxgbetool.8

cxgbetool.8: Fix Minor mechanical issuesClosedPublicActions