Page MenuHomeFreeBSD
Differential D50176

flua: add posix.unistd.dup2()
ClosedPublic
Actions

Authored by ifreund_freebsdfoundation.org on Mon, May 5, 8:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 18, 8:15 PM
Unknown Object (File)
Sun, May 18, 1:58 PM
Unknown Object (File)
Mon, May 12, 1:42 PM
Unknown Object (File)
Mon, May 12, 7:47 AM
Unknown Object (File)
Fri, May 9, 10:42 AM
Unknown Object (File)
Thu, May 8, 11:06 PM
Unknown Object (File)
Thu, May 8, 10:53 PM
Unknown Object (File)
Thu, May 8, 4:29 PM
Subscribers
imp

Details

Reviewers
emaste
kevans
Commits
rG909aa6781340: flua: add posix.unistd.dup2()
Summary

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64083
Build 60967: arc lint + arc unit

Event Timeline

ifreund_freebsdfoundation.org created this revision.Mon, May 5, 8:48 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, May 5, 8:48 PM
ifreund_freebsdfoundation.org requested review of this revision.Mon, May 5, 8:48 PM
Harbormaster completed remote builds in B63918: Diff 154899.Mon, May 5, 8:48 PM
ifreund_freebsdfoundation.org added a child revision: D50177: flua: add posix.unistd.execp.Mon, May 5, 8:48 PM
imp added inline comments.Tue, May 6, 12:21 AM
libexec/flua/modules/lposix.c
175

why doesn't this require a goto err too?

ifreund_freebsdfoundation.org added inline comments.Tue, May 6, 7:58 AM
libexec/flua/modules/lposix.c
175

This function raises a lua error on failure and does not return.

Internally it longjmps away to somewhere else in the lua VM and either invokes an error handler if in a pcall() context or prints a stack trace and exits.

The luaL_checkinteger calls below behave the same.

emaste accepted this revision.Tue, May 6, 3:06 PM
emaste added inline comments.
libexec/flua/modules/lposix.c
174

We seem to have a number of different styles for the arg and extramsg args of luaL_argcheck

  • _exit narg == 1, 1
  • basename narg > 0, 1
  • chmod n == 2, n > 2 ? 3 : n
  • chown n > 1, n

some include the function (close takes exactly one argument (fd)) while some do not (at least one argument required).

Independent of this change we could do a pass to rationalize these

This revision is now accepted and ready to land.Tue, May 6, 3:06 PM
ifreund_freebsdfoundation.org added inline comments.Fri, May 9, 2:44 PM
libexec/flua/modules/lposix.c
174

I opened D50273 to clean this up.

ifreund_freebsdfoundation.org added a comment.Sun, May 11, 9:01 AM

My git branch for this patch stack is here: https://github.com/ifreund/freebsd-src/commits/bsdinstall-pkgbase-components/

ifreund_freebsdfoundation.org updated this revision to Diff 155290.Sun, May 11, 3:27 PM

Use new enforce_max_args() function from D50273

This revision now requires review to proceed.Sun, May 11, 3:27 PM
Harbormaster completed remote builds in B64083: Diff 155290.Sun, May 11, 3:27 PM
emaste accepted this revision.Sun, May 11, 3:30 PM
This revision is now accepted and ready to land.Sun, May 11, 3:30 PM
emaste added a comment.Sun, May 11, 3:31 PM

As an aside while MFCing some flua work I (re)discovered 1f31e00e19f9e24d4c891a24973e08a027c4f71c

ifreund_freebsdfoundation.org added a comment.Mon, May 12, 7:27 AM
In D50176#1147472, @emaste wrote:

As an aside while MFCing some flua work I (re)discovered 1f31e00e19f9e24d4c891a24973e08a027c4f71c

Interesting, I wasn't aware of fbsd.exec. Unfortunately it doesn't look flexible enough to support the bsddialog use-case as it lacks a way to capture stderr output.

Closed by commit rG909aa6781340: flua: add posix.unistd.dup2() (authored by ifreund_freebsdfoundation.org, committed by emaste). · Explain WhyMon, May 12, 1:40 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG909aa6781340: flua: add posix.unistd.dup2().

Revision Contents
Changeset List

PathSize
libexec/
flua/
modules/
35 lines

Diff 155290

View Options

libexec/flua/modules/lposix.c

Loading...