Page MenuHomeFreeBSD
Differential D50233

fts: Add FTS_COMFOLLOWDIR and FTS_NOSTAT_TYPE.
ClosedPublic
Actions

Authored by des on Wed, May 7, 11:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 11, 2:59 PM
Unknown Object (File)
Sun, May 11, 9:01 AM
Unknown Object (File)
Sat, May 10, 3:13 PM
Unknown Object (File)
Thu, May 8, 6:44 PM
Unknown Object (File)
Thu, May 8, 4:00 PM
Unknown Object (File)
Thu, May 8, 3:42 PM
Unknown Object (File)
Thu, May 8, 1:02 PM
Subscribers
imp
kevans
ziaee

Details

Reviewers
imp
kevans
Group Reviewers
Klara
Commits
rGda2025a0e894: fts: Add FTS_COMFOLLOWDIR and FTS_NOSTAT_TYPE.
Summary

MFC after: never
Relnotes: yes
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63987
Build 60871: arc lint + arc unit

Event Timeline

des created this revision.Wed, May 7, 11:32 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptWed, May 7, 11:32 AM
des requested review of this revision.Wed, May 7, 11:32 AM
Harbormaster completed remote builds in B63987: Diff 155043.Wed, May 7, 11:32 AM
des added a child revision: D50234: fts: Add tests for most FTS options..Wed, May 7, 11:32 AM
des added a parent revision: D50218: fts: Drop obsolete conditionals..Wed, May 7, 11:33 AM
imp accepted this revision.Wed, May 7, 8:39 PM
This revision is now accepted and ready to land.Wed, May 7, 8:39 PM
kevans added a subscriber: kevans.Thu, May 8, 1:03 AM
kevans added inline comments.
lib/libc/gen/fts.c
914

I'd be tempted to add a default case since d_type isn't an enum. What are we doing with, e.g., DT_UNKNOWN?

des added inline comments.Thu, May 8, 6:19 AM
lib/libc/gen/fts.c
914

I'm not sure DT_UNKNOWN can happen, but leaving it unchanged as FTS_NSOK is fine.

des marked an inline comment as done.Thu, May 8, 6:19 AM
kevans added inline comments.Thu, May 8, 11:49 AM
lib/libc/gen/fts.c
914

Sure, works for me. cd9660 has a DT_UNK OWN tendency, fwiw.

kevans accepted this revision.Thu, May 8, 11:49 AM
Closed by commit rGda2025a0e894: fts: Add FTS_COMFOLLOWDIR and FTS_NOSTAT_TYPE. (authored by des). · Explain WhyThu, May 8, 2:30 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGda2025a0e894: fts: Add FTS_COMFOLLOWDIR and FTS_NOSTAT_TYPE..

Revision Contents
Changeset List

PathSize
include/
6 lines
lib/
libc/
gen/
22 lines
45 lines

Diff 155043

View Options

include/fts.h

Loading...
View Options

lib/libc/gen/fts.3

Loading...
View Options

lib/libc/gen/fts.c

Loading...