Page MenuHomeFreeBSD
Differential D50233

fts: Add FTS_COMFOLLOWDIR and FTS_NOSTAT_TYPE.
ClosedPublic
Actions

Authored by des on May 7 2025, 11:32 AM.
Tags
None
Referenced Files
F172361753: D50233.diff
Thu, Sep 17, 11:18 PM
Unknown Object (File)
Sun, Sep 13, 6:24 AM
Unknown Object (File)
Sun, Sep 13, 6:24 AM
Unknown Object (File)
Sat, Sep 12, 12:51 AM
Unknown Object (File)
Sun, Sep 6, 6:08 PM
Unknown Object (File)
Sun, Sep 6, 3:37 PM
Unknown Object (File)
Sat, Sep 5, 1:15 PM
Unknown Object (File)
Sat, Sep 5, 9:01 AM
View All Files
Subscribers
imp
kevans
ziaee

Details

Reviewers
imp
kevans
Group Reviewers
Klara
Commits
rGda2025a0e894: fts: Add FTS_COMFOLLOWDIR and FTS_NOSTAT_TYPE.
Summary

MFC after: never
Relnotes: yes
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.May 7 2025, 11:32 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptMay 7 2025, 11:32 AM
des requested review of this revision.May 7 2025, 11:32 AM
Harbormaster completed remote builds in B63987: Diff 155043.May 7 2025, 11:32 AM
des added a child revision: D50234: fts: Add tests for most FTS options..May 7 2025, 11:32 AM
des added a parent revision: D50218: fts: Drop obsolete conditionals..May 7 2025, 11:33 AM
imp accepted this revision.May 7 2025, 8:39 PM
This revision is now accepted and ready to land.May 7 2025, 8:39 PM
kevans added a subscriber: kevans.May 8 2025, 1:03 AM
kevans added inline comments.
lib/libc/gen/fts.c
914

I'd be tempted to add a default case since d_type isn't an enum. What are we doing with, e.g., DT_UNKNOWN?

des added inline comments.May 8 2025, 6:19 AM
lib/libc/gen/fts.c
914

I'm not sure DT_UNKNOWN can happen, but leaving it unchanged as FTS_NSOK is fine.

des marked an inline comment as done.May 8 2025, 6:19 AM
kevans added inline comments.May 8 2025, 11:49 AM
lib/libc/gen/fts.c
914

Sure, works for me. cd9660 has a DT_UNK OWN tendency, fwiw.

kevans accepted this revision.May 8 2025, 11:49 AM
Closed by commit rGda2025a0e894: fts: Add FTS_COMFOLLOWDIR and FTS_NOSTAT_TYPE. (authored by des). · Explain WhyMay 8 2025, 2:30 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGda2025a0e894: fts: Add FTS_COMFOLLOWDIR and FTS_NOSTAT_TYPE..

Revision Contents
Changeset List

PathSize
include/
6 lines
lib/
libc/
gen/
22 lines
45 lines

Diff 155133

View Options

include/fts.h

Loading...
View Options

lib/libc/gen/fts.3

Loading...
View Options

lib/libc/gen/fts.c

Loading...