Page MenuHomeFreeBSD

fts: Add tests for most FTS options.
ClosedPublic

Authored by des on May 7 2025, 11:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 10, 12:09 PM
Unknown Object (File)
Mon, Jul 7, 11:37 AM
Unknown Object (File)
Wed, Jun 25, 12:31 AM
Unknown Object (File)
Wed, Jun 18, 8:30 PM
Unknown Object (File)
Tue, Jun 17, 8:16 PM
Unknown Object (File)
Tue, Jun 17, 7:08 PM
Unknown Object (File)
Sun, Jun 15, 4:00 AM
Unknown Object (File)
Sat, Jun 14, 7:06 PM
Subscribers

Details

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.May 7 2025, 11:32 AM
This revision is now accepted and ready to land.May 7 2025, 8:40 PM
kevans added a subscriber: kevans.
kevans added inline comments.
lib/libc/tests/gen/fts_options.c
53

That's cute, I kind of wish we had some atf-c(3) support for this instead to abstract away that particular detail. That's fine for now, unless you didn't intend to leave it in.

des marked an inline comment as done.May 8 2025, 6:23 AM
des added inline comments.
lib/libc/tests/gen/fts_options.c
53

On the contrary, this is the compromise I arrived at to avoid removing the fprintf() at the top of the loop in fts_options_test(), because I don't want it in regular test output, but this test is hopeless to debug without it.

des marked an inline comment as done.May 8 2025, 6:23 AM
This revision was automatically updated to reflect the committed changes.