Paths

Table of Contentst

Differential D50234

fts: Add tests for most FTS options.
ClosedPublic
Actions

Authored by des on May 7 2025, 11:32 AM.

Tags

None

Referenced Files

	F173023235: D50234.diff
	Tue, Sep 22, 10:59 PM

	Unknown Object (File)
	Mon, Sep 7, 10:51 AM

	Unknown Object (File)
	Fri, Sep 4, 11:55 PM

	Unknown Object (File)
	Fri, Sep 4, 6:15 AM

	Unknown Object (File)
	Fri, Sep 4, 1:33 AM

	Unknown Object (File)
	Wed, Sep 2, 8:13 AM

	Unknown Object (File)
	Wed, Sep 2, 4:38 AM

	Unknown Object (File)
	Wed, Sep 2, 1:30 AM

Subscribers

Details

Reviewers

imp
kevans

Group Reviewers

Commits

rGd2da6ed98494: fts: Add tests for most FTS options.

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.May 7 2025, 11:32 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 7 2025, 11:32 AM

des requested review of this revision.May 7 2025, 11:32 AM

Harbormaster completed remote builds in B63988: Diff 155044.May 7 2025, 11:32 AM

des added a parent revision: D50233: fts: Add FTS_COMFOLLOWDIR and FTS_NOSTAT_TYPE..May 7 2025, 11:32 AM

des added a child revision: D50235: fts: Give the blocks test a description..

imp accepted this revision.May 7 2025, 8:40 PM

This revision is now accepted and ready to land.May 7 2025, 8:40 PM

kevans accepted this revision.May 8 2025, 1:25 AM

kevans added a subscriber: kevans.

kevans added inline comments.

lib/libc/tests/gen/fts_options.c
53	That's cute, I kind of wish we had some atf-c(3) support for this instead to abstract away that particular detail. That's fine for now, unless you didn't intend to leave it in.

des marked an inline comment as done.May 8 2025, 6:23 AM

des added inline comments.

lib/libc/tests/gen/fts_options.c
53	On the contrary, this is the compromise I arrived at to avoid removing the `fprintf()` at the top of the loop in `fts_options_test()`, because I don't want it in regular test output, but this test is hopeless to debug without it.

des marked an inline comment as done.May 8 2025, 6:23 AM

Closed by commit rGd2da6ed98494: fts: Add tests for most FTS options. (authored by des). · Explain WhyMay 8 2025, 2:30 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGd2da6ed98494: fts: Add tests for most FTS options..

Revision Contents
Changeset List

Path

Size

lib/

libc/

tests/

gen/

1 line

454 lines

Diff 155135

lib/libc/tests/gen/Makefile

Loading...

lib/libc/tests/gen/fts_options.c

Loading...