ClosedPublic
Actions

Authored by ivy on May 6 2025, 8:34 AM.

Details

Reviewers

des
kevans

Commits

rGbbffdfef3bf0: link_addr_test: use <cstddef>, not <sys/stddef.h>

Summary

<cstddef> is the correct header; this fixes the GCC build.

Fixes: 757e973fb211 ("libc tests: add tests for link_addr(3) and link_ntoa(3)")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63935
Build 60819: arc lint + arc unit

Event Timeline

ivy created this revision.May 6 2025, 8:34 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 6 2025, 8:34 AM

ivy requested review of this revision.May 6 2025, 8:34 AM

Harbormaster completed remote builds in B63933: Diff 154924.May 6 2025, 8:34 AM

des added inline comments.May 6 2025, 9:30 AM

lib/libc/tests/net/link_addr_test.cc
23–24
36	any reason not to sort these?

sort the headers

i've separated the C headers from the C++ headers and sorted them separately; i
don't know if we have any existing style guidelines for that but it's how i
usually prefer to do it, otherwise you end up with a bunch of C headers
randomly sorted under 'c'.

Harbormaster completed remote builds in B63935: Diff 154927.May 6 2025, 9:59 AM

I would have preferred not to split them, but no strong opinion either way.

This revision is now accepted and ready to land.May 6 2025, 2:35 PM

Closed by commit rGbbffdfef3bf0: link_addr_test: use <cstddef>, not <sys/stddef.h> (authored by ivy). · Explain WhyMay 6 2025, 2:51 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rGbbffdfef3bf0: link_addr_test: use <cstddef>, not <sys/stddef.h>.

ivy mentioned this in rG2f8ba2e5b93e: libc tests: add tests for link_addr(3) and link_ntoa(3).May 20 2025, 9:53 PM

ivy mentioned this in rG55f0de279306: libc tests: add tests for link_addr(3) and link_ntoa(3).May 21 2025, 12:30 AM