umass: Simplify umass_std_transform to eliminate fake success
ClosedPublic
Actions

Authored by imp on Mar 23 2025, 9:50 PM.

Details

Reviewers

mav
ken
markj
chs

Commits

rG49633d5d02e1: umass: Simplify umass_std_transform to eliminate fake success

Summary

Now that nothing returns (2) to fake the success of the command,
eliminate that magic number by eliminating the case.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63899
Build 60783: arc lint + arc unit

Event Timeline

imp requested review of this revision.Mar 23 2025, 9:50 PM

imp created this revision.

Harbormaster completed remote builds in B63076: Diff 152568.Mar 23 2025, 9:50 PM

imp added a parent revision: D49468: umass: Fail SYNCHRONIZE_CACHE for UFI.Mar 23 2025, 9:50 PM

imp added a child revision: D49470: umass: make *_transform() return a bool.

imp added reviewers: mav, ken, markj.Mar 24 2025, 1:04 AM

imp added a reviewer: chs.Apr 2 2025, 8:04 PM

rebase

Harbormaster completed remote builds in B63899: Diff 154866.May 5 2025, 4:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2025, 9:37 PM

Closed by commit rG49633d5d02e1: umass: Simplify umass_std_transform to eliminate fake success (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG49633d5d02e1: umass: Simplify umass_std_transform to eliminate fake success.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

storage/

umass.c

19 lines

Diff 154866

View Options

sys/dev/usb/storage/umass.c

umass: Simplify umass_std_transform to eliminate fake successClosedPublicActions