umass: Fail SYNCHRONIZE_CACHE for UFI
ClosedPublic
Actions

Authored by imp on Mar 23 2025, 9:50 PM.

Details

Reviewers

mav
markj
ken
chs

Commits

rGa945c21a6101: umass: Fail SYNCHRONIZE_CACHE for UFI

Summary

Just go ahead and fail SYNCHRONIZE_CACHE commands for UFI. This standard
doesn't have a cache to flush, and the upper layers (aka da) will notice sync
cache failed and won't send it again.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63898
Build 60782: arc lint + arc unit

Event Timeline

imp requested review of this revision.Mar 23 2025, 9:50 PM

imp created this revision.

imp added a parent revision: D49467: umass: Document the ideal that it's better to fail bad commands.

Harbormaster completed remote builds in B63075: Diff 152567.Mar 23 2025, 9:50 PM

imp added a child revision: D49469: umass: Simplify umass_std_transform to eliminate fake success.Mar 23 2025, 9:50 PM

imp added reviewers: mav, markj, ken.Mar 24 2025, 1:05 AM

imp added a reviewer: chs.Apr 2 2025, 8:04 PM

rebase

Harbormaster completed remote builds in B63898: Diff 154865.May 5 2025, 4:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2025, 9:37 PM

Closed by commit rGa945c21a6101: umass: Fail SYNCHRONIZE_CACHE for UFI (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGa945c21a6101: umass: Fail SYNCHRONIZE_CACHE for UFI.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

storage/

umass.c

7 lines

Diff 154865

View Options

sys/dev/usb/storage/umass.c

umass: Fail SYNCHRONIZE_CACHE for UFIClosedPublicActions