efivar: Add some explicit casts to uuid_t
ClosedPublic
Actions

Authored by imp on Apr 25 2025, 7:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 26, 2:48 PM

	Unknown Object (File)
	Wed, Nov 26, 6:12 AM

	Unknown Object (File)
	Sun, Nov 23, 12:31 PM

	Unknown Object (File)
	Sun, Nov 23, 12:28 PM

	Unknown Object (File)
	Sun, Nov 23, 12:28 PM

	Unknown Object (File)
	Sun, Nov 23, 12:25 PM

	Unknown Object (File)
	Sun, Nov 23, 10:54 AM

	Unknown Object (File)
	Tue, Nov 18, 4:35 PM

View All 56 Files

Subscribers

None

Details

Reviewers

tsoome
kevans
kib

Commits

rGcdfaf4e984a4: efivar: Add some explicit casts to uuid_t

Summary

Since we know we're type-punning the EFI_GUID to a uuid_t, add some
explicit casts even though, at the moment, we typedef one to the other.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Apr 25 2025, 7:33 PM

imp created this revision.

Harbormaster completed remote builds in B63737: Diff 154302.Apr 25 2025, 7:33 PM

imp added a child revision: D50033: efivar: Use memcmp instead of uuid_ functions to compare.Apr 25 2025, 7:33 PM

I would add some type-checking for the conversion. E.g you could define inlines uuid_t * efi_guid_to_uuid(efi_guid_t *) and const uuid_t *const_efi_guid_to_uuid(const efi_guid_t *) and use them instead of manually writing the cast.

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2025, 6:06 PM

Closed by commit rGcdfaf4e984a4: efivar: Add some explicit casts to uuid_t (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGcdfaf4e984a4: efivar: Add some explicit casts to uuid_t.

Revision Contents
Changeset List

Path

Size

lib/

libefivar/

efivar.c

12 lines

Diff 154634

View Options

efivar: Add some explicit casts to uuid_tClosedPublicActions