Differential D50073

racct: Fix accounting of CPU time for the system idle process
ClosedPublic
Actions

Authored by markj on Apr 29 2025, 2:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 3, 1:10 PM

	Unknown Object (File)
	Wed, Sep 3, 9:01 AM

	Unknown Object (File)
	Mon, Sep 1, 12:53 AM

	Unknown Object (File)
	Sun, Aug 31, 7:30 AM

	Unknown Object (File)
	Tue, Aug 26, 1:10 AM

	Unknown Object (File)
	Sat, Aug 23, 8:26 PM

	Unknown Object (File)
	Wed, Aug 13, 12:59 PM

	Unknown Object (File)
	Jul 18 2025, 4:54 PM

View All 27 Files

Subscribers

Details

Reviewers

kib
olce

Commits

rG33be1632047c: racct: Fix accounting of CPU time for the system idle process

Summary

Add a flag which cleanly indicates that a given process is the system idle process.
Modify racctd() to skip over the idle proc when aggregating CPU time and other metrics which don't apply to the idle thread.
Remove handling for idle threads from racct_getpcpu().

PR: 269097
MFC after: 2 weeks
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Apr 29 2025, 2:53 PM

Herald added subscribers: olce, imp. · View Herald TranscriptApr 29 2025, 2:53 PM

markj requested review of this revision.Apr 29 2025, 2:53 PM

Harbormaster completed remote builds in B63779: Diff 154476.Apr 29 2025, 2:53 PM

kib accepted this revision.Apr 29 2025, 3:35 PM

kib added inline comments.

sys/kern/kern_racct.c
314	?

This revision is now accepted and ready to land.Apr 29 2025, 3:35 PM

olce accepted this revision.Apr 29 2025, 3:39 PM

markj added inline comments.Apr 30 2025, 1:27 PM

sys/kern/kern_racct.c
314	I'll fix this separately.

Closed by commit rG33be1632047c: racct: Fix accounting of CPU time for the system idle process (authored by markj). · Explain WhyMay 1 2025, 2:23 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG33be1632047c: racct: Fix accounting of CPU time for the system idle process.

Revision Contents
Changeset List

Path

Size

sys/

kern/

3 lines

22 lines

sys/

2 lines

Diff 154622

sys/kern/kern_idle.c

Loading...

sys/kern/kern_racct.c

Loading...

sys/sys/proc.h

Loading...