Page MenuHomeFreeBSD

efivar: Add some explicit casts to uuid_t
ClosedPublic

Authored by imp on Apr 25 2025, 7:33 PM.
Tags
None
Referenced Files
F167106708: D50032.id154302.diff
Wed, Aug 19, 3:38 AM
Unknown Object (File)
Tue, Aug 18, 2:23 PM
Unknown Object (File)
Tue, Aug 18, 6:43 AM
Unknown Object (File)
Mon, Aug 17, 4:18 PM
Unknown Object (File)
Mon, Aug 17, 2:52 AM
Unknown Object (File)
Wed, Aug 12, 12:02 AM
Unknown Object (File)
Mon, Aug 10, 6:58 PM
Unknown Object (File)
Sun, Aug 9, 7:14 PM
Subscribers
None

Details

Summary

Since we know we're type-punning the EFI_GUID to a uuid_t, add some
explicit casts even though, at the moment, we typedef one to the other.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63737
Build 60621: arc lint + arc unit

Event Timeline

imp requested review of this revision.Apr 25 2025, 7:33 PM
imp created this revision.

I would add some type-checking for the conversion. E.g you could define inlines uuid_t * efi_guid_to_uuid(efi_guid_t *) and const uuid_t *const_efi_guid_to_uuid(const efi_guid_t *) and use them instead of manually writing the cast.

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2025, 6:06 PM
This revision was automatically updated to reflect the committed changes.