Paths

Table of Contentst

Differential D49980

sound: Make sndstat PVCHAN and RVCHAN nvlist parameters bool
ClosedPublic
Actions

Authored by christos on Apr 23 2025, 1:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 15, 4:05 PM

	Unknown Object (File)
	Fri, Aug 15, 2:58 PM

	Unknown Object (File)
	Thu, Aug 14, 11:48 PM

	Unknown Object (File)
	Sun, Aug 10, 10:26 PM

	Unknown Object (File)
	Sun, Aug 10, 10:21 PM

	Unknown Object (File)
	Sat, Aug 2, 3:10 AM

	Unknown Object (File)
	Tue, Jul 29, 1:10 AM

	Unknown Object (File)
	Mon, Jul 28, 3:29 AM

View All 47 Files

Subscribers

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rG3b0ff20f8d69: sound: Make sndstat PVCHAN and RVCHAN nvlist parameters bool
rG0c0bb4c1401c: sound: Make sndstat PVCHAN and RVCHAN nvlist parameters bool

Summary

Prior to 02d4eeabfd73 ("sound: Allocate vchans on-demand"), the
play.vchans and rec.vchans sysctls corresponded to the value of
d->pvchancount and d->rvchancount respectively, which is also what we
are exporting through SNDST_DSPS_SOUND4_PVCHAN and
SNDST_DSPS_SOUND4_RVCHAN respectively. Since that commit, the sysctls
mentioned have been modified to show whether play/rec vchans are enabled
or not. Modify the sndstat nvlist parameters accordingly.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63671
Build 60555: arc lint + arc unit

Event Timeline

christos created this revision.Apr 23 2025, 1:05 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptApr 23 2025, 1:05 PM

christos requested review of this revision.Apr 23 2025, 1:05 PM

Harbormaster completed remote builds in B63671: Diff 154162.Apr 23 2025, 1:05 PM

christos added a child revision: D49981: sndstat.4: Make sndstat nvlist channel names reflect new naming scheme.Apr 23 2025, 1:05 PM

christos added a child revision: D46227: audio(8): Initial revision.Apr 23 2025, 1:05 PM

nvlist_add_number() -> nvlist_add_bool()

Harbormaster completed remote builds in B63673: Diff 154165.Apr 23 2025, 1:14 PM

christos added a child revision: D49983: sound: Export hardware and software buffer sample rate in sndstat nvlist.Apr 23 2025, 3:08 PM

christos removed a child revision: D46227: audio(8): Initial revision.

christos removed a child revision: D49981: sndstat.4: Make sndstat nvlist channel names reflect new naming scheme.

christos mentioned this in D46227: audio(8): Initial revision.Apr 23 2025, 3:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2025, 4:57 PM

Closed by commit rG0c0bb4c1401c: sound: Make sndstat PVCHAN and RVCHAN nvlist parameters bool (authored by christos). · Explain Why

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG0c0bb4c1401c: sound: Make sndstat PVCHAN and RVCHAN nvlist parameters bool.

christos added a commit: rG3b0ff20f8d69: sound: Make sndstat PVCHAN and RVCHAN nvlist parameters bool.May 2 2025, 10:47 AM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

8 lines

sys/

dev/

sound/

pcm/

6 lines

Diff 154162

share/man/man4/sndstat.4

Loading...

sys/dev/sound/pcm/sndstat.c

Loading...