Page MenuHomeFreeBSD
Differential D49792

pci: Don't re-route legacy PCI on MSI/MSIX devs
Needs ReviewPublic
Actions

Authored by cperciva on Apr 12 2025, 12:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 5, 3:12 PM
Unknown Object (File)
Wed, Nov 5, 3:00 PM
Unknown Object (File)
Wed, Nov 5, 2:57 PM
Unknown Object (File)
Wed, Nov 5, 4:29 AM
Unknown Object (File)
Tue, Nov 4, 10:18 PM
Unknown Object (File)
Mon, Nov 3, 9:24 PM
Unknown Object (File)
Sun, Oct 26, 1:55 PM
Unknown Object (File)
Thu, Oct 16, 5:23 PM
View All 36 Files
Subscribers
bz
imp

Details

Reviewers
jhb
jrtc27
jhibbits
Summary

There is a (very historical) call to pci_assign_interrupt for the
purpose of routing PCI IRQs. On INTRNG systems this can cause a
(synthetic) IRQ leak and ultimately a kernel panic after many
hotplug/unplug cycles.

Since this should only be necessary on legacy PCI, disable it for
devices which use MSI/MSIX.

MFC after: 2 weeks
Sponsored by: Amazon

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63472
Build 60356: arc lint + arc unit

Event Timeline

cperciva created this revision.Apr 12 2025, 12:46 AM
Herald added a subscriber: imp. · View Herald TranscriptApr 12 2025, 12:46 AM
cperciva requested review of this revision.Apr 12 2025, 12:46 AM
Harbormaster completed remote builds in B63472: Diff 153558.Apr 12 2025, 12:46 AM
cperciva added a comment.Apr 12 2025, 12:49 AM

@jhb This avoids the IRQ leak on the EC2 instance I was having trouble with before. I think you suggested that this was only necessary for non-MSI/MSIX devices before I went down the (wrong) route of making it x86-only.

@jrtc27 @jhibbits Can you try this patch on your systems and let me know if it causes problems?

jhb added inline comments.Apr 12 2025, 12:12 PM
sys/dev/pci/pci.c
4178

The problem with this is that the driver might still choose to use INTx (or the admin might have disabled MSI via tunable, etc.) and since cfg->intline isn't invalid, we won't try to check it.

Maybe we need to encode this differently and only call pci_assign_interrupt() the first time pci_alloc_resource() tries to alloc the INTx interrupt. The IRQ in dmesg might still be wrong in this case though.

cperciva added a subscriber: bz.Apr 15 2025, 6:45 PM
cperciva added inline comments.
sys/dev/pci/pci.c
4178

Oh, I assumed that systems were either MSI/MSIX or legacy... I didn't realize they might be both. Earlier commits in this section of code (e.g. when @bz added __PCI_REROUTE_INTERRUPT to arm64 in 3d9ac4ecfcba638fbbc9ec7925fea08206198deb he noted that this "was not needed on real hardware (yet) as it was always MSI".

At this point I'm wondering if I should just hide this behind a loader tunable, "hw.pci.no_legacy_reroute" since that way I can fix the panic on EC2 without potentially breaking weird systems.

cperciva mentioned this in D49849: pci: Add hw.pci.intx_reroute sysctl/tunable.Apr 15 2025, 8:03 PM
jhb added inline comments.Apr 21 2025, 6:08 PM
sys/dev/pci/pci.c
4178

It's not even a hardwired thing. Drivers can choose which type of interrupt to use at runtime. Legacy PCI only supported INTx originally, so many/most devices still support those. MSI is mandated by PCI-express, so most modern devices support both. However, some earlier PCI-express devices had bugs and require INTx instead of MSI. Generally speaking newer devices should be using MSI since it is more flexible and more performant, but INTx is still around.

cperciva added inline comments.Apr 21 2025, 6:45 PM
sys/dev/pci/pci.c
4178

Got it. You ok with my tunable workaround? https://reviews.freebsd.org/D49849

Revision Contents
Changeset List

PathSize
sys/
dev/
pci/
3 lines

Diff 153558

View Options

sys/dev/pci/pci.c

Loading...