umass: Be more consistent about how we fail bad commands
ClosedPublic
Actions

Authored by imp on Mar 23 2025, 9:50 PM.

Details

Reviewers

markj
ken
mav
chs

Commits

rG43030e34453b: umass: Be more consistent about how we fail bad commands

Summary

Elsewhere, if we fail a command, we use SCSI code ILLEGAL REQUEST/24/00,
but here we were using the CAM code for illegal request.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63080
Build 59964: arc lint + arc unit

Event Timeline

imp requested review of this revision.Mar 23 2025, 9:50 PM

imp created this revision.

Harbormaster completed remote builds in B63080: Diff 152572.Mar 23 2025, 9:50 PM

imp added a parent revision: D49472: umass: Move INQUIRY and TEST UNIT READY quirks to umass_std_transform.Mar 23 2025, 9:50 PM

imp added a child revision: D49474: umass: Fix a direct call to sc_transform.

imp added reviewers: markj, ken, mav.Mar 24 2025, 1:02 AM

imp added a reviewer: chs.Apr 2 2025, 8:06 PM

rebase

Harbormaster completed remote builds in B63903: Diff 154870.May 5 2025, 4:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 7 2025, 9:37 PM

Closed by commit rG43030e34453b: umass: Be more consistent about how we fail bad commands (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG43030e34453b: umass: Be more consistent about how we fail bad commands.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

storage/

umass.c

5 lines

Diff 152572

View Options

sys/dev/usb/storage/umass.c

umass: Be more consistent about how we fail bad commandsClosedPublicActions